pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Xuneng Zhou <xunengzhou@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: per backend WAL statistics
Date: Tue, 11 Mar 2025 23:14:24 -0400
Message-ID: <1870853.1741749264@sss.pgh.pa.us> (raw)
In-Reply-To: <Z89-gxOVxtEP_w9d@paquier.xyz>
References: <Z8hLi1dGfPFc8AYy@ip-10-97-1-34.eu-west-3.compute.internal>
	<clef2a7wqnopfjw3jl7pbn25gko6m3fk2zctmtqjgyx6a7xw5j@sujsipmj4zif>
	<Z8iJUHn13NsSCYhj@ip-10-97-1-34.eu-west-3.compute.internal>
	<Z8l6EMM4ImVoWRkg@ip-10-97-1-34.eu-west-3.compute.internal>
	<Z8qHNelALLU6LiSy@paquier.xyz>
	<Z8qvQFG/70pt33E0@ip-10-97-1-34.eu-west-3.compute.internal>
	<Z8ukEg7Z3KsNfEoo@paquier.xyz>
	<Z8v3YIvhNTrhzhZb@ip-10-97-1-34.eu-west-3.compute.internal>
	<Z86Y7cDkebuIhsDj@paquier.xyz>
	<Z87SetO+E/QOayNP@ip-10-97-1-34.eu-west-3.compute.internal>
	<Z89-gxOVxtEP_w9d@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> And I guess that we're OK here, so applied.  That should be the last
> one.

Quite a few buildfarm members are not happy about the initialization
that 9a8dd2c5a added to PendingBackendStats.  For instance [1]:

gcc -std=gnu99 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O2 -I. -I. -I../../../../src/include  -D_GNU_SOURCE -I/usr/include/libxml2   -c -o pgstat_backend.o pgstat_backend.c
pgstat_backend.c:39:1: warning: missing braces around initializer [-Wmissing-braces]
 static PgStat_BackendPending PendingBackendStats = {0};
 ^
pgstat_backend.c:39:1: warning: (near initialization for \342\200\230PendingBackendStats.pending_io\342\200\231) [-Wmissing-braces]

I guess that more than one level of braces is needed for this to
be fully correct?  Similar from ayu, batfish, boa, buri, demoiselle,
dhole, rhinoceros, shelduck, siskin.

			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=arowana&dt=2025-03-11%2004%3A59%3A...





view thread (77+ messages)  latest in thread

Message-ID: <1870853.1741749264@sss.pgh.pa.us>
Permalink:  ../1870853.1741749264@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1870853.1741749264@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, bertranddrouvot.pg@gmail.com, andres@anarazel.de, xunengzhou@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: per backend WAL statistics
  In-Reply-To: <1870853.1741749264@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox