From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavel Borisov <pashkin.elfe@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: OOM in spgist insert
Date: Fri, 14 May 2021 09:40:53 -0400
Message-ID: <1880876.1620999653@sss.pgh.pa.us> (raw)
In-Reply-To: <CALT9ZEHztoWa2stNE9J1gCdj-zMJodN0a9ng0HF1mXtOspmfKQ@mail.gmail.com>
References: <20210513224933.GA20201@alvherre.pgsql>
<1785221.1620954078@sss.pgh.pa.us>
<CAFiTN-t8Ms6K-e5vk3iPm+z8HV6UWgzmxDRzDhfJZxfWoOYe_g@mail.gmail.com>
<CALT9ZEHztoWa2stNE9J1gCdj-zMJodN0a9ng0HF1mXtOspmfKQ@mail.gmail.com>
Pavel Borisov <pashkin.elfe@gmail.com> writes:
> Now when checking for shortening of leaf tuple is added LongValuesOK
> become slightly redundant. I'd propose to replace it with more legible name
> as LongValuesOK doesn't mean they are warranted to be ok just that we can
> try to shorten them? What about tryShortening, trySuffixing or
> can(Try)ShortenTuple?
That field name is part of the opclass API. I fear it's several years
too late to rename it for no compelling reason.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pashkin.elfe@gmail.com, dilipbalaut@gmail.com, alvherre@alvh.no-ip.org
Subject: Re: OOM in spgist insert
In-Reply-To: <1880876.1620999653@sss.pgh.pa.us>
References: <20210513224933.GA20201@alvherre.pgsql> <1785221.1620954078@sss.pgh.pa.us> <CAFiTN-t8Ms6K-e5vk3iPm+z8HV6UWgzmxDRzDhfJZxfWoOYe_g@mail.gmail.com> <CALT9ZEHztoWa2stNE9J1gCdj-zMJodN0a9ng0HF1mXtOspmfKQ@mail.gmail.com> <1880876.1620999653@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox