agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Antonin Houska <ah@cybertec.at>
To: Osama Abdul Qader <osamaabdulqader.cs@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: Alvaro Herrera <alvherre@kurilemu.de>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: REPACK (ANALYZE) within transaction block segfaults
Date: Fri, 04 Sep 2026 14:54:57 +0200
Message-ID: <18948.1788526497@localhost> (raw)
In-Reply-To: <CAC+8b5iYeoG2+8u3Wdz7N4qJFK3PXr5t1wjDu2UbmP2As=VM1Q@mail.gmail.com>
References: <apfbHj9TkfvlOeJ3@alvherre.pgsql>
<15397.1788338846@localhost>
<CAC+8b5ha_W8S_qaK1DUj_Z=+gQQX7PfSyfypLafgtXF=zhRrQA@mail.gmail.com>
<5477.1788410526@localhost>
<CAC+8b5gsq+W_Re-h-wYC4c2F-HCZf9FZ-rs00COFpddKjr7Q7g@mail.gmail.com>
<CAC+8b5hZ0d9UNNGSh8LwCFytmuTx0cQszUZo2aJ9kSYRaOSTTg@mail.gmail.com>
<CAHGQGwGKdV8Hw-f430qacdtEGkYnc-DbQd0W1opx+wCO9fcdxg@mail.gmail.com>
<CAC+8b5gCW3gU7KS1Jj=csgYkMhQ75DeKAPB15e9BT+4ZsbGLJw@mail.gmail.com>
<CAC+8b5iYeoG2+8u3Wdz7N4qJFK3PXr5t1wjDu2UbmP2As=VM1Q@mail.gmail.com>
Osama Abdul Qader <osamaabdulqader.cs@gmail.com> wrote:
> I've updated the patch to address your comments:
>
> * Documented that 'REPACK (ANALYZE)' cannot be used inside a transaction block, or from a function, procedure or 'DO' block.
> * Updated the comment in repack.c to clarify that this restriction is intentional for now, consistently with VACUUM (FULL, ANALYZE).
In [1] I added a comment explaining why it's a problem to run REPACK (ANALYZE)
from function. I thought it's important so that, when we conclude (in the
future) that running in block is fine, we still keep checking for execution
from a function. (PreventInTransactionBlock() checks both at the moment.)
In [2] I was advised to make the comment more precise, but as you appear to
have taken the patch over, I expected that you'll do that. However, you simply
removed that part of the comment. Can you please explain why?
BTW, "top posting" is not the preferred style in this mailing list [3].
[1] https://www.postgresql.org/message-id/49398.1787944525%40localhost
[2] https://www.postgresql.org/message-id/CAHGQGwEezdMUixhJ-N0YO0OFUmh0uPaXRDkds5FS-5dmdwz4Bg%40mail.gma...
[3] https://wiki.postgresql.org/wiki/Mailing_Lists
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
view thread (25+ messages) latest in thread
Message-ID: <18948.1788526497@localhost>
Permalink: ../18948.1788526497@localhost/
Also on: postgresql.org/message-id/18948.1788526497@localhost
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ah@cybertec.at, osamaabdulqader.cs@gmail.com, masao.fujii@gmail.com, alvherre@kurilemu.de, nathandbossart@gmail.com
Subject: Re: REPACK (ANALYZE) within transaction block segfaults
In-Reply-To: <18948.1788526497@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox