agora inbox for pgsql-hackers@postgresql.org  
help / color / mirror / Atom feed
From: Antonin Houska <ah@cybertec.at>
To: Osama Abdul Qader <osamaabdulqader.cs@gmail.com>
Cc: Alvaro Herrera <alvherre@kurilemu.de>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: REPACK (ANALYZE) within transaction block segfaults
Date: Thu, 03 Sep 2026 06:42:06 +0200
Message-ID: <5477.1788410526@localhost> (raw)
In-Reply-To: <CAC+8b5ha_W8S_qaK1DUj_Z=+gQQX7PfSyfypLafgtXF=zhRrQA@mail.gmail.com>
References: <apfbHj9TkfvlOeJ3@alvherre.pgsql>
	<15397.1788338846@localhost>
	<CAC+8b5ha_W8S_qaK1DUj_Z=+gQQX7PfSyfypLafgtXF=zhRrQA@mail.gmail.com>

Osama Abdul Qader <osamaabdulqader.cs@gmail.com> wrote:

> I have prepared a patch that rejects REPACK (ANALYZE) with PreventInTransactionBlock(), consistent with the existing restriction for
> REPACK (CONCURRENTLY). I also added a regression test covering execution inside a transaction block.
> 
> The patch applies cleanly to the current tree and passes git diff --check.

Is this a new version of [1]? If so, I'm not sure it addresses all the
problems mentioned in [2]. And regarding regression tests, it misses the
changes in expected/cluster.out.


[1] https://www.postgresql.org/message-id/49398.1787944525%40localhost
[2] https://www.postgresql.org/message-id/CAHGQGwEezdMUixhJ-N0YO0OFUmh0uPaXRDkds5FS-5dmdwz4Bg%40mail.gma...

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com






view thread (25+ messages)  latest in thread

Message-ID: <5477.1788410526@localhost>
Permalink:  ../5477.1788410526@localhost/
Also on:    postgresql.org/message-id/5477.1788410526@localhost

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: ah@cybertec.at, osamaabdulqader.cs@gmail.com, alvherre@kurilemu.de, masao.fujii@gmail.com, nathandbossart@gmail.com
  Subject: Re: REPACK (ANALYZE) within transaction block segfaults
  In-Reply-To: <5477.1788410526@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox