From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <pchampion@vmware.com>
Cc: sfrost@snowman.net <sfrost@snowman.net>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: Fixing cache pollution in the Kerberos test suite
Date: Mon, 25 Jan 2021 14:04:34 -0500
Message-ID: <1895343.1611601474@sss.pgh.pa.us> (raw)
In-Reply-To: <0c0cbc9b9a7a1bcd6e78e5eddf706ddeba0293da.camel@vmware.com>
References: <1fcb175bafef6560f47a8c31229fa7c938486b8d.camel@vmware.com>
<20210125183645.GF27507@tamriel.snowman.net>
<1894698.1611600541@sss.pgh.pa.us>
<0c0cbc9b9a7a1bcd6e78e5eddf706ddeba0293da.camel@vmware.com>
Jacob Champion <pchampion@vmware.com> writes:
> On Mon, 2021-01-25 at 13:49 -0500, Tom Lane wrote:
>> Yeah, changing global state is just awful. However, I don't
>> actually see any change here (RHEL8):
> Interesting. I'm running Ubuntu 20.04:
Hmm. I'll poke harder.
>> Also, why are you only setting the ENV variable within narrow parts
>> of the test script? I'd be inclined to enforce it throughout.
> I considered it and decided I didn't want to pollute the server's
> environment with it, since the server shouldn't need the client cache.
True, but if it did try to access the cache, accessing the user's
normal cache would be strictly worse than accessing the test cache.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pchampion@vmware.com, sfrost@snowman.net, pgsql-hackers@lists.postgresql.org
Subject: Re: Fixing cache pollution in the Kerberos test suite
In-Reply-To: <1895343.1611601474@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox