pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Continue work on changes to recovery.conf API
Date: Fri, 28 Sep 2018 16:45:49 -0400
Message-ID: <1902.1538167549@sss.pgh.pa.us> (raw)
In-Reply-To: <20180928204042.boqbpggazp656ie7@alap3.anarazel.de>
References: <607741529606767@web3g.yandex.ru>
	<594281529606887@web2j.yandex.ru>
	<3595211530445522@web17o.yandex.ru>
	<64b6e400-74fa-3b30-5bcf-4d6a1facbf27@2ndquadrant.com>
	<1312381535557435@iva1-a2ffb02749cf.qloud-c.yandex.net>
	<22e02b05-cd56-6a6b-962d-6d35995827a5@2ndquadrant.com>
	<1563.1538166995@sss.pgh.pa.us>
	<20180928204042.boqbpggazp656ie7@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2018-09-28 16:36:35 -0400, Tom Lane wrote:
>> No, they MUST be independently verifiable.  The interactions between
>> the check_xxx functions in this patch are utterly unsafe.  We've
>> learned that lesson before.

> I'm not sure those concerns apply quite the same way here - we can move
> the interdependent verification to the the point where they're used
> first rather than relying on guc.c infrastructure.

And, if they're bad, what happens?  Recovery fails?

I don't think it's a great idea to lose out on whatever error checking
the existing GUC infrastructure can provide, just so as to use a GUC
design that's not very nice in the first place.

			regards, tom lane




view thread (40+ messages)  latest in thread

Message-ID: <1902.1538167549@sss.pgh.pa.us>
Permalink:  ../1902.1538167549@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1902.1538167549@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, peter.eisentraut@2ndquadrant.com, sk@zsrv.org
  Subject: Re: Continue work on changes to recovery.conf API
  In-Reply-To: <1902.1538167549@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox