public inbox for [email protected]
help / color / mirror / Atom feedFrom: Daniel Gustafsson <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall
Date: Thu, 9 May 2024 21:58:37 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <20240509193425.GA3219615@nathanxps13>
References: <20240503171348.GA1731524@nathanxps13>
<[email protected]>
<20240508183850.GA2824188@nathanxps13>
<[email protected]>
<[email protected]>
<20240509193425.GA3219615@nathanxps13>
> On 9 May 2024, at 21:34, Nathan Bossart <[email protected]> wrote:
>
> On Thu, May 09, 2024 at 09:03:56AM +0900, Michael Paquier wrote:
>> +1. Could there be an argument in favor of a backpatch? This is a
>> performance improvement, but one could also side that the addition of
>> sync support in pg_dump[all] has made that a regression that we'd
>> better fix because the flushes don't matter in this context. They
>> also bring costs for no gain.
>
> I don't see a strong need to back-patch this, if for no other reason than
> it seems to have gone unnoticed for 7 major versions. Plus, based on my
> admittedly limited testing, this is unlikely to provide significant
> improvements.
Agreed, this is a nice little improvement but it's unlikely to be enough of a
speedup to warrant changing the backbranches.
--
Daniel Gustafsson
view thread (7+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox