public inbox for [email protected]
help / color / mirror / Atom feedFrom: Peter Eisentraut <[email protected]>
To: Nathan Bossart <[email protected]>
To: [email protected]
Subject: Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall
Date: Wed, 8 May 2024 10:09:46 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <20240503171348.GA1731524@nathanxps13>
References: <20240503171348.GA1731524@nathanxps13>
On 03.05.24 19:13, Nathan Bossart wrote:
> This is likely small potatoes compared to some of the other
> pg_upgrade-related improvements I've proposed [0] [1] or plan to propose,
> but this is easy enough, and I already wrote the patch, so here it is.
> AFAICT there's no reason to bother syncing these dump files to disk. If
> someone pulls the plug during pg_upgrade, it's not like you can resume
> pg_upgrade from where it left off. Also, I think we skipped syncing before
> v10, anyway, as the --no-sync flag was only added in commit 96a7128, which
> added the code to sync dump files, too.
Looks good to me.
view thread (7+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox