From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Add -Wold-style-definition to CFLAGS?
Date: Sat, 09 May 2020 19:11:56 -0400
Message-ID: <19295.1589065916@sss.pgh.pa.us> (raw)
In-Reply-To: <20200509184354.hpkxuvip64nlnqve@alap3.anarazel.de>
References: <20200509174820.g4bwftmz7blz35ph@alap3.anarazel.de>
<4838.1589048101@sss.pgh.pa.us>
<20200509184354.hpkxuvip64nlnqve@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2020-05-09 14:15:01 -0400, Tom Lane wrote:
>> Andres Freund <andres@anarazel.de> writes:
>>> Since gcc has a warning detecting such definition, I think we ought to
>>> automatically add it when available?
>> +1
> Any opinion about waiting for branching or not?
I'd be OK with pushing it now, but I dunno about other people.
If we do want to push this sort of thing now, the nearby changes
to enable fallthrough warnings should go in too.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de
Subject: Re: Add -Wold-style-definition to CFLAGS?
In-Reply-To: <19295.1589065916@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox