From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Quan Zongliang <quanzongliang@yeah.net>
Cc: pgsql-hackers@postgresql.org
Subject: Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.
Date: Thu, 08 Jul 2021 00:49:25 -0400
Message-ID: <1932991.1625719765@sss.pgh.pa.us> (raw)
In-Reply-To: <20210708042806.GA22043@telsasoft.com>
References: <8b8ec36e-61fe-14f9-005d-07bc85aa4eed@yeah.net>
<CALj2ACVvmn7RsV9BmXLKv9M-7WZtabyyALECsY_iKbz4Cj1VtA@mail.gmail.com>
<YOZ70IxyhdGzn6OE@paquier.xyz>
<20210708042806.GA22043@telsasoft.com>
Justin Pryzby <pryzby@telsasoft.com> writes:
> On Thu, Jul 08, 2021 at 01:15:12PM +0900, Michael Paquier wrote:
>> Changes in the object set of an extension requires a new SQL script
>> that changes the objects to reflect the change. So, in this case,
>> what you need to do is to create pageinspect--1.9--1.10.sql, assuming
>> that the new extension version is 1.10 and change page_header()
>> accordingly.
> I think it's common (and preferred) for changes in extension versions to be
> "folded" together within a major release of postgres. Since v1.9 is new in
> pg14 (commit 756ab2912), this change can be included in the same, new version.
Since we're already past beta2, I'm not sure that's a good idea. We
can't really treat pageinspect 1.9 as something that the world has
never seen.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pryzby@telsasoft.com, michael@paquier.xyz, bharath.rupireddyforpostgres@gmail.com, quanzongliang@yeah.net
Subject: Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.
In-Reply-To: <1932991.1625719765@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox