pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dave Page <dpage@postgresql.org>
Cc: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pl/perl extension fails on Windows
Date: Thu, 17 Aug 2017 12:15:58 -0400
Message-ID: <19438.1502986558@sss.pgh.pa.us> (raw)
In-Reply-To: <17646.1502983856@sss.pgh.pa.us>
References: <CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com>
	<4569.1499873707@sss.pgh.pa.us>
	<CA+OCxox=h5xftcnyk1AfA_QKSQSruD=Er0qweZakiCEg3U4rcg@mail.gmail.com>
	<20170713195345.2q6zmrtxumljhoui@msg.df7cb.de>
	<3254.1501276475@sss.pgh.pa.us>
	<20170730211444.uvedz2a24gusoaxr@msg.df7cb.de>
	<CAE9k0PnzYxyKHuwJonUEDt2xunPUc8VUVPWsd0BScRd3u+j8_A@mail.gmail.com>
	<20170731084044.q3wmppgt556zafzy@msg.df7cb.de>
	<30582.1501508356@sss.pgh.pa.us>
	<20170731164517.a34wxaapos7u5toj@msg.df7cb.de>
	<CANFyU96tucWPECj8Oy5cevuVwyijVoEZ_Dey08eCEhPk9TM85A@mail.gmail.com>
	<CA+TgmoZTu6wyjJ3vZNLuogCvXv9uwH0Xr+RMhJbo3L8f2eSVFg@mail.gmail.com>
	<CANFyU95XuHw8ajYHhg8BPdRSAa++n7MAHxpoEho90nPiEsTRKw@mail.gmail.com>
	<CA+Tgmob8We1gMW6mA-AKtc_Mx1LAGx9+aHOjmBEu_PYGDSpZkg@mail.gmail.com>
	<CAE9k0Pm9YcJqqkWXGvSQrkPGbH_f29VF7+=YzKNGOgnwnufa2Q@mail.gmail.com>
	<CA+TgmoZ6dGEb7Yr9v8JdLX=KtAtdOTcD8PQUbDxVTGBazpQ-QQ@mail.gmail.com>
	<12588.1502375771@sss.pgh.pa.us>
	<14838.1502379286@sss.pgh.pa.us>
	<1708! 2.1502718166@sss.pgh.pa.us>
	<10406.1502743029@sss.pgh.pa.us>
	<CA+OCxow_P_K9kpsSeMwdnqoiaAx3YEDN6P1s-93L5A_iTUYHuw@mail.gmail.com>
	<1914.1502978317@sss.pgh.pa.us>
	<CA+OCxow3A8waWr3drvFtmBwfgD8RF6w7rC2z9eY8eMJ7zz3y4w@mail.gmail.com>
	<4515.1502981857@sss.pgh.pa.us>
	<17646.1502983856@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

I wrote:
> Short of declaring this version of Perl unsupported, the only answer
> I can think of is to put a kluge into the MSVC build scripts along
> the lines of "if it's 32-bit Windows, and the Perl version is before X,
> assume we need _USE_32BIT_TIME_T even if $Config{ccflags} doesn't
> say so".  It would be nice to have some hard evidence about what X
> should be, but we don't know when ActiveState fixed this.  (I poked
> around in their bugzilla, without success.)

Ah-hah: it wasn't ActiveState that fixed this at all; it was upstream
Perl.  The stanza that Ashutosh found about defining _USE_32BIT_TIME_T
originated in Perl 5.13.4; older Perls simply don't provide it, no
matter how they were built.

We can now isolate the exact reason we're having trouble on baiji:
it's building Postgres with MSVC 2005, which by default will think
time_t is 64 bits, but it must be using a copy of Perl that was
built with an older Microsoft compiler that doesn't think that.
(Dave's "perl -V" output says ccversion='12.00.8804', but I don't
know how to translate that to the marketing version.)  And since it's
pre-5.13.4, Perl itself doesn't know it should advertise this fact.

So it's now looking to me like we should do the above with X = 5.13.4.
That won't be a perfect solution, but it's about the best we can
readily do.  Realistically, nobody out in the wider world is likely
to care about building current PG releases against such old Perl
versions on Windows; if we satisfy our older buildfarm critters,
it's enough for me.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (94+ messages)  latest in thread

Message-ID: <19438.1502986558@sss.pgh.pa.us>
Permalink:  ../19438.1502986558@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/19438.1502986558@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dpage@postgresql.org, sandeep.thakkar@enterprisedb.com, ashu.coek88@gmail.com, robertmhaas@gmail.com
  Subject: Re: pl/perl extension fails on Windows
  In-Reply-To: <19438.1502986558@sss.pgh.pa.us>
  References: <CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com> <20170731084044.q3wmppgt556zafzy@msg.df7cb.de> <30582.1501508356@sss.pgh.pa.us> <20170731164517.a34wxaapos7u5toj@msg.df7cb.de> <CANFyU96tucWPECj8Oy5cevuVwyijVoEZ_Dey08eCEhPk9TM85A@mail.gmail.com> <CA+TgmoZTu6wyjJ3vZNLuogCvXv9uwH0Xr+RMhJbo3L8f2eSVFg@mail.gmail.com> <CANFyU95XuHw8ajYHhg8BPdRSAa++n7MAHxpoEho90nPiEsTRKw@mail.gmail.com> <CA+Tgmob8We1gMW6mA-AKtc_Mx1LAGx9+aHOjmBEu_PYGDSpZkg@mail.gmail.com> <CAE9k0Pm9YcJqqkWXGvSQrkPGbH_f29VF7+=YzKNGOgnwnufa2Q@mail.gmail.com> <CA+TgmoZ6dGEb7Yr9v8JdLX=KtAtdOTcD8PQUbDxVTGBazpQ-QQ@mail.gmail.com> <12588.1502375771@sss.pgh.pa.us> <14838.1502379286@sss.pgh.pa.us> <10406.1502743029@sss.pgh.pa.us> <CA+OCxow_P_K9kpsSeMwdnqoiaAx3YEDN6P1s-93L5A_iTUYHuw@mail.gmail.com> <1914.1502978317@sss.pgh.pa.us> <CA+OCxow3A8waWr3drvFtmBwfgD8RF6w7rC2z9eY8eMJ7zz3y4w@mail.gmail.com> <4515.1502981857@sss.pgh.pa.us> <17646.1502983856@sss.pgh.pa.us> <19438.1502986558@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox