From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org, Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: David Fetter <david@fetter.org>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Synchronize with imath upstream
Date: Thu, 07 Feb 2019 10:12:05 -0500
Message-ID: <19483.1549552325@sss.pgh.pa.us> (raw)
In-Reply-To: <20190207055011.GB392703@rfd.leadboat.com>
References: <20190205234750.GA2774@alvherre.pgsql>
<FB934CD7-B508-4523-B920-F0EE9CCB1756@anarazel.de>
<23413.1549466124@sss.pgh.pa.us>
<20190207055011.GB392703@rfd.leadboat.com>
Noah Misch <noah@leadboat.com> writes:
> On Wed, Feb 06, 2019 at 10:15:24AM -0500, Tom Lane wrote:
>> I don't object to keeping imported code in a form that matches upstream
>> as best we can. (Should we also exclude such files from pgindent'ing?)
> I think it depends on how much time one spends merging upstream changes versus
> making PostgreSQL-specific edits. For IMath, both amounts are too small to
> get excited about. Does pgindent materially complicate src/timezone merges?
My practice with src/timezone is to pgindent the upstream code and then
diff it; given that extra step, it's not really any more complex (and
maybe less so, as this hides minor whitespace changes for instance).
There are some other deltas to worry about as well, see
src/timezone/README.
I have no particular opinion on whether pgindent should be part of the
mix for imath, but I do strongly recommend setting up and documenting a
reproducible import process, as I did for src/timezone.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, noah@leadboat.com, andres@anarazel.de, alvherre@2ndquadrant.com, david@fetter.org, andrew@tao11.riddles.org.uk
Subject: Re: Synchronize with imath upstream
In-Reply-To: <19483.1549552325@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox