agora inbox for [email protected]
help / color / mirror / Atom feedFrom: Antonin Houska <[email protected]>
To: Richard Guo <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: [HACKERS] WIP: Aggregation push-down
Date: Wed, 17 Jul 2019 16:39:52 +0200
Message-ID: <19857.1563374392@localhost> (raw)
In-Reply-To: <CAN_9JTzAsBwv5zr4SRVO35OtMWQBXSLcUuY65NQ0ZtFCTOrMMA@mail.gmail.com>
References: <29613.1502983342@localhost>
<14577.1509723225@localhost>
<CAB7nPqQgB=3ZpuvSm8hVXDcPz79kn2ZGsyyoDrmQsv-B3LDMyQ@mail.gmail.com>
<18007.1513957437@localhost>
<CA+Tgmob8og+9HzMg1vM+3LwDm2f_bHUi9+g1bqLDTjqpw5s+nQ@mail.gmail.com>
<31585.1519833763@localhost>
<18061.1535727958@localhost>
<[email protected]>
<15879.1545062283@localhost>
<10529.1547561178@localhost>
<[email protected]>
<25767.1549359615@localhost>
<[email protected]>
<23468.1551369774@localhost>
<CAN_9JTy95UMjOVDSc-4MBrA6Fc1hX2vh=t2RMHp=yGyAV=-Xsw@mail.gmail.com>
<[email protected]>
<CAN_9JTzC1K-Gc3p5GD=dQeJD8k_Z5996B0rEYjVGx+pXPq8JPw@mail.gmail.com>
<[email protected]>
<CAN_9JTzAsBwv5zr4SRVO35OtMWQBXSLcUuY65NQ0ZtFCTOrMMA@mail.gmail.com>
Richard Guo <[email protected]> wrote:
> Another core dump for query below:
>
> select sum(t1.s1) from t1, t2, t3, t4 where t1.j1 = t2.j2 group by t1.g1, t2.g2;
>
> This is due to a small mistake:
>
> diff --git a/src/backend/optimizer/util/relnode.c b/src/backend/optimizer/util/relnode.c
> index 10becc0..9c2deed 100644
> --- a/src/backend/optimizer/util/relnode.c
> +++ b/src/backend/optimizer/util/relnode.c
> @@ -648,7 +648,7 @@ void
> add_grouped_rel(PlannerInfo *root, RelOptInfo *rel, RelAggInfo *agg_info)
> {
> add_rel_info(root->grouped_rel_list, rel);
> - add_rel_info(root->agg_info_list, rel);
> + add_rel_info(root->agg_info_list, agg_info);
> }
>
Thanks! Yes, this is what I had to fix.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
view thread (59+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: [HACKERS] WIP: Aggregation push-down
In-Reply-To: <19857.1563374392@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox