pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: walther@technowledgy.de
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: PRI?64 vs Visual Studio (2022)
Date: Mon, 15 Dec 2025 12:05:38 -0500
Message-ID: <1991599.1765818338@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+hUKGJaX3AcuKSdEUOZiWc+mzL=+dvGnbMqCvWGY22y6oh9Nw@mail.gmail.com>
References: <20250331.152829.1921392690375275165.horikyota.ntt@gmail.com>
	<001bdc3b-ef94-4f24-b017-ac8ff0a2ea55@eisentraut.org>
	<CA+hUKGJnmzTqiODmTjf-23yZ=E3HXqFTtKoyp3TF-MpB93hTMQ@mail.gmail.com>
	<1372793.1763519315@sss.pgh.pa.us>
	<CA+hUKGLzXzQcbjEHW08Z6g=mzBkpLtzSJ7Bt2S2XmxP1bwpq8A@mail.gmail.com>
	<1377512.1763522154@sss.pgh.pa.us>
	<e7b902aa-98ac-4d35-bae3-d7d282a938c2@eisentraut.org>
	<1462038.1763567038@sss.pgh.pa.us>
	<CA+hUKG+nMv9bmOcARaDFC6rG=SGWC=TwWSRLrxi29oGeRNKemg@mail.gmail.com>
	<1881391.1765782112@sss.pgh.pa.us>
	<CA+hUKGJaX3AcuKSdEUOZiWc+mzL=+dvGnbMqCvWGY22y6oh9Nw@mail.gmail.com>

Thomas Munro <thomas.munro@gmail.com> writes:
> On Mon, Dec 15, 2025 at 8:01 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> What to do now?  I could revert 8c498479d and followups, but
>> I sure don't want to.  A stopgap measure to make the farm look
>> green would be to add a variant expected-file that accepts
>> this output, but yech.  Thoughts?

> So close yet so far... I tried asking if it's easy to fix:

> https://github.com/sabotage-linux/gettext-tiny/issues/76

Hmm, not sure if you found the live upstream for that project, but if
you did, this code hasn't been touched since 2019.  Think we shouldn't
hold our breath for a fix :-(.  I will go add another expected-file.

I'm also thinking that maybe we should expand the ambition of that
test script a little.  Instead of only checking the behavior of PRI*
when we can test translation, why not run the ereport's all the time?
This would at least test that <inttypes.h> is sane and snprintf.c
agrees with it, which we now know is something worth checking.  That's
colored by seeing that less than half of the buildfarm is finding any
variant of es_ES to test in.  That's not great, but I'm not seeing
anything to be done about it.  The only locale names we can be sure
will be accepted are C/POSIX, and I'd expect gettext() to
short-circuit that case and not look for a translation.  I'm thinking
though that it's still worth checking that the untranslated string is
processed correctly.

			regards, tom lane





view thread (41+ messages)  latest in thread

Message-ID: <1991599.1765818338@sss.pgh.pa.us>
Permalink:  ../1991599.1765818338@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1991599.1765818338@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, thomas.munro@gmail.com, peter@eisentraut.org, horikyota.ntt@gmail.com, walther@technowledgy.de, pgsql-hackers@lists.postgresql.org
  Subject: Re: PRI?64 vs Visual Studio (2022)
  In-Reply-To: <1991599.1765818338@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox