pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Bruce Momjian <maillist@candle.pha.pa.us>
To: tih@nhh.no
Cc: lockhart@alumni.caltech.edu
Cc: taral@mail.utexas.edu
Cc: hackers@postgreSQL.org
Subject: Re: [HACKERS] Open 6.4 items
Date: Mon, 12 Oct 1998 11:57:13 -0400 (EDT)
Message-ID: <199810121557.LAA12136@candle.pha.pa.us> (raw)
In-Reply-To: <86ww65yfmu.fsf@athene.nhh.no>

Both applied, with the first one reverse applied.  Thanks.


> Bruce Momjian <maillist@candle.pha.pa.us> writes:
> 
> > I have lost it.  Could someone resend it, and the patch to reverse too.
> 
> This is the one that shouldn't have been applied:
> 
> Index: inet_net_pton.c
> ===================================================================
> RCS file: /usr/local/cvsroot/pgsql/src/backend/utils/adt/inet_net_pton.c,v
> retrieving revision 1.2
> diff -r1.2 inet_net_pton.c
> 120c120
> < 			else if (size-- > 0)
> ---
> > 			else if (--size > 0)
> 
> This is the one that works:
> 
> Index: inet_net_pton.c
> ===================================================================
> RCS file: /usr/local/cvsroot/pgsql/src/backend/utils/adt/inet_net_pton.c,v
> retrieving revision 1.2
> diff -r1.2 inet_net_pton.c
> 108c108,109
> < 		*dst = 0, dirty = 0;
> ---
> > 		tmp = 0;
> > 		dirty = 0;
> 117,122c118,127
> < 			*dst |= n;
> < 			if (!dirty++)
> < 				*dst <<= 4;
> < 			else if (size-- > 0)
> < 				*++dst = 0, dirty = 0;
> < 			else
> ---
> > 			tmp = (tmp << 4) | n;
> > 			if (++dirty == 2) {
> > 				if (size-- <= 0)
> > 					goto emsgsize;
> > 				*dst++ = (u_char) tmp;
> > 				tmp = 0, dirty = 0;
> > 			}
> > 		}
> > 		if (dirty) {
> > 			if (size-- <= 0)
> 123a129,130
> > 			tmp <<= 4;
> > 			*dst++ = (u_char) tmp;
> 125,126d131
> < 		if (dirty)
> < 			size--;
> 
> -tih
> -- 
> Popularity is the hallmark of mediocrity.  --Niles Crane, "Frasier"
> 


-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

view thread (141+ messages)  latest in thread

Message-ID: <199810121557.LAA12136@candle.pha.pa.us>
Permalink:  ../199810121557.LAA12136@candle.pha.pa.us/
Also on:    postgresql.org/message-id/199810121557.LAA12136@candle.pha.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: maillist@candle.pha.pa.us, tih@nhh.no, lockhart@alumni.caltech.edu, taral@mail.utexas.edu, hackers@postgreSQL.org
  Subject: Re: [HACKERS] Open 6.4 items
  In-Reply-To: <199810121557.LAA12136@candle.pha.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox