From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)
Date: Thu, 19 Jan 2017 13:06:20 -0500
Message-ID: <19999.1484849180@sss.pgh.pa.us> (raw)
In-Reply-To: <20170118221154.aldebi7yyjvds5qa@alap3.anarazel.de>
References: <837.1484680521@sss.pgh.pa.us>
<12780.1484747004@sss.pgh.pa.us>
<20170118191924.25lfp6rd6y3kw5sa@alap3.anarazel.de>
<13690.1484767452@sss.pgh.pa.us>
<20170118193420.znochutmnzusd636@alap3.anarazel.de>
<15814.1484769612@sss.pgh.pa.us>
<460325A6-EF35-4A29-A1A0-EEDC3EDCF750@anarazel.de>
<22709.1484771072@sss.pgh.pa.us>
<20170118214702.54b2mdbxce5piwv5@alap3.anarazel.de>
<1080.1484776606@sss.pgh.pa.us>
<20170118221154.aldebi7yyjvds5qa@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Andres Freund <andres@anarazel.de> writes:
> On 2017-01-18 16:56:46 -0500, Tom Lane wrote:
>> Andres Freund <andres@anarazel.de> writes:
>> I have not actually looked at 0003 at all yet. So yeah, please post
>> for review after you're done rebasing.
> Here's a rebased and lightly massaged version.
I've read through this and made some minor improvements, mostly additional
comment cleanup. One thing I wanted to ask about:
@@ -4303,7 +4303,7 @@ inline_function(Oid funcid, Oid result_type, Oid result_collid,
/*
* Forget it if the function is not SQL-language or has other showstopper
- * properties. (The nargs check is just paranoia.)
+ * properties. (The nargs and retset checks are just paranoia.)
*/
if (funcform->prolang != SQLlanguageId ||
funcform->prosecdef ||
I thought this change was simply wrong, and removed it; AFAIK it's
perfectly possible to get here for set-returning functions, since
the planner does expression simplification long before it worries
about splitting out SRFs. Did you have a reason to think differently?
Other than that possible point, I think the attached is committable.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackersAttachments:
[application/x-gzip] no-srfs-in-tlists-cleanup-2.patch.gz (27.7K, ../19999.1484849180@sss.pgh.pa.us/2-no-srfs-in-tlists-cleanup-2.patch.gz)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com
Subject: Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)
In-Reply-To: <19999.1484849180@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox