pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)
Date: Tue, 17 Jan 2017 14:15:21 -0500
Message-ID: <837.1484680521@sss.pgh.pa.us> (raw)
In-Reply-To: <20170117185346.z55d3jnsaf24yr4m@alap3.anarazel.de>
References: <20161031160639.nyxoktszi5psl2cc@alap3.anarazel.de>
	<20170116032952.z2re55hcfhzbkmrm@alap3.anarazel.de>
	<20170116083316.2izqrxbvmyalazac@alap3.anarazel.de>
	<21924.1484593998@sss.pgh.pa.us>
	<CA+TgmoboiMYk1jTL-=2a0iukktCoDnKHMhrQ9za8JrMvkFdYUw@mail.gmail.com>
	<29207.1484675540@sss.pgh.pa.us>
	<20170117180324.dqgz23xaf6wtazb4@alap3.anarazel.de>
	<30268.1484677082@sss.pgh.pa.us>
	<CA+TgmoZm9sARp1Sv8A3Ar7Mf+cKVhHriGt-oFro6VgKocgOUYg@mail.gmail.com>
	<32021.1484678618@sss.pgh.pa.us>
	<20170117185346.z55d3jnsaf24yr4m@alap3.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Andres Freund <andres@anarazel.de> writes:
> On 2017-01-17 13:43:38 -0500, Tom Lane wrote:
>> I'm not convinced that that optimization is worth preserving, but if we
>> keep it then ProjectSet isn't le mot juste here, any more than you'd want
>> to rename Result to Project without changing its existing
>> functionality.

> Right. I'd removed that, and re-added it; primarily because the plans
> looked more complex without it. After all, you'd thought it worth adding
> that hack ;)   I'm happy with removing it again too.

Well, it seemed reasonable to do that as long as the only cost was ten or
so lines in create_projection_plan.  But if we're contorting not only the
behavior but the very name of the SRF-evaluation plan node type, that's
not negligible cost anymore.  So now I'm inclined to take it out.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (110+ messages)  latest in thread

Message-ID: <837.1484680521@sss.pgh.pa.us>
Permalink:  ../837.1484680521@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/837.1484680521@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com
  Subject: Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)
  In-Reply-To: <837.1484680521@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox