pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Euler Taveira <euler@eulerto.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Jacob Champion <jacob.champion@enterprisedb.com>
Cc: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Dave Cramer <davecramer@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: More protocol.h replacements this time into walsender.c
Date: Wed, 06 Aug 2025 14:54:13 -0300
Message-ID: <1a1b279e-69d7-4609-924e-8d52f1201ef0@app.fastmail.com> (raw)
In-Reply-To: <aJLLc1JHMEcvU9mj@nathan>
References: <CADK3HHLs-8fTiYikJBU45bkMYABVifkYPQU9s3vwO4EUcuOo=w@mail.gmail.com>
	<202508041231.myxuzx2udlze@alvherre.pgsql>
	<aJEQUTYLkS836qu5@nathan>
	<CAOYmi+nQ75D+OcyDa0cH3q5Hh_vioErtDgXHMaNGK4xfeG2EPA@mail.gmail.com>
	<aJEk695hVaEc4ve3@nathan>
	<aJJidMu-E-qD9hrG@nathan>
	<797cad77-647b-42c4-89b8-fd5bf8a8fd10@app.fastmail.com>
	<aJLLc1JHMEcvU9mj@nathan>

On Wed, Aug 6, 2025, at 12:26 AM, Nathan Bossart wrote:
> Okay, I think I've addressed all the latest feedback in v5.
>

LGTM.

I tried to apply your patch and it says

$ git am -3 v5-0001-Expand-usage-of-protocol-characters.patch
Applying: Expand usage of protocol characters.
Warning: commit message did not conform to UTF-8.
You may want to amend it after fixing the message, or set the config
variable i18n.commitEncoding to the encoding your project uses.

It seems your file is ISO-8859-1 but your commit message claims to be UTF-8.


-- 
Euler Taveira
EDB   https://www.enterprisedb.com/





view thread (29+ messages)  latest in thread

Message-ID: <1a1b279e-69d7-4609-924e-8d52f1201ef0@app.fastmail.com>
Permalink:  ../1a1b279e-69d7-4609-924e-8d52f1201ef0@app.fastmail.com/
Also on:    postgresql.org/message-id/1a1b279e-69d7-4609-924e-8d52f1201ef0@app.fastmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: euler@eulerto.com, nathandbossart@gmail.com, jacob.champion@enterprisedb.com, alvherre@kurilemu.de, davecramer@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: More protocol.h replacements this time into walsender.c
  In-Reply-To: <1a1b279e-69d7-4609-924e-8d52f1201ef0@app.fastmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox