pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: WIP: BRIN multi-range indexes
Date: Fri, 26 Mar 2021 14:08:03 +0100
Message-ID: <1da94012-f512-ffc8-dd5e-888d862b662e@enterprisedb.com> (raw)
In-Reply-To: <357fb6d7-649f-822e-ff43-16b39aed68ee@enterprisedb.com>
References: <20210303001725.GA1766@alvherre.pgsql>
	<23a0a854-8f1a-e965-7121-f76b1b2fc271@enterprisedb.com>
	<cf8fca26-0fdd-ac74-5dac-66a2ccb59f56@enterprisedb.com>
	<8e319879-32ff-1eb8-d7d3-6a3ac8a51728@enterprisedb.com>
	<CAFBsxsHrqP+OMp5cV6yiEzkwobtAp4rnxOGsfm_s_vX8qSNQeQ@mail.gmail.com>
	<35e866e9-d820-07de-b2be-69d5ac479179@enterprisedb.com>
	<71dfd257-c5ce-530d-90d3-7c744a28e97b@enterprisedb.com>
	<CAFBsxsHswPBXQvvW87uSR59MkPNhEB5Txe4sFjVBfE9TR4jrGw@mail.gmail.com>
	<ea369ea5-0d61-bbee-c1c7-bfe17728bab1@enterprisedb.com>
	<54b47e66-bd8a-d44a-2090-fd4b2f49abe6@enterprisedb.com>
	<357fb6d7-649f-822e-ff43-16b39aed68ee@enterprisedb.com>

Hi,

I've pushed both the bloom and minmax-multi indexes today.

Based on the feedback and limitations described before I decided to keep
them in core (i.e. not move them to contrib), but it was very useful
experiment as it uncovered a couple issues - both in existing code, and
in the definition of the new opclasses.

After further thought I've concluded that the decision to ditch the old
signature (in a1c649d889) was probably wrong, so I've added the support
back, per what Alexander originally proposed.

While doing so, I've noticed that the NULL handling may be a few bricks
shy, because with (oi_regular_nulls == false) it should probably keep
passing the NULL scan keys to the consistent function. I'll look into
that and get it fixed.


Thanks everyone who helped with those patches!

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





view thread (177+ messages)  latest in thread

Message-ID: <1da94012-f512-ffc8-dd5e-888d862b662e@enterprisedb.com>
Permalink:  ../1da94012-f512-ffc8-dd5e-888d862b662e@enterprisedb.com/
Also on:    postgresql.org/message-id/1da94012-f512-ffc8-dd5e-888d862b662e@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@enterprisedb.com, john.naylor@enterprisedb.com, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: WIP: BRIN multi-range indexes
  In-Reply-To: <1da94012-f512-ffc8-dd5e-888d862b662e@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox