public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Alex Guo <[email protected]>
Cc: Bertrand Drouvot <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Cc: [email protected]
Subject: Re: Fix DROP PROPERTY GRAPH "unsupported object class" error
Date: Sun, 07 Jun 2026 20:28:40 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <aen77u5go8P7RJaL@bdtpg>
	<CAExHW5vfxVCQFADhiEmi3goyOgGb5qQjURHaM2QDtW6CksUzWA@mail.gmail.com>
	<aet7rawq/V07+H1L@bdtpg>
	<CAExHW5vJGHDXyLDAVC3eJF_ykU73AB9CG6HvJ+WtmO+GE4dnzA@mail.gmail.com>
	<afM8dgqqxsxqmnY7@bdtpg>
	<CAExHW5udMZbMKiQFWB=hDeAK+=t2PXPrmBuscpUc3888kzAi2A@mail.gmail.com>
	<afmHd5vSCJtMFueS@bdtpg>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Michael Paquier <[email protected]> writes:
> + property graph element label  |        |      | e of e of
> create_property_graph_tests.gt
> + property graph element label  |        |      | v1 of v1 of
> create_property_graph_tests.gt
> + property graph element label  |        |      | v2 of v2 of
> create_property_graph_tests.gt
> [...]
> + property graph label property |        |      | c of e of e of
> create_property_graph_tests.gt
> + property graph label property |        |      | k1 of e of e of
> create_property_graph_tests.gt
> + property graph label property |        |      | k2 of e of e of
> create_property_graph_tests.gt

> FWIW, I still find these descriptions written as of "$object of
> $object of..", or worse the "$object1 of $object2 of $object2 of..",
> really hard to parse, and make some sense out of them.  Am I the only
> one?

No.  At the very least, these messages violate our style guidelines [1]:

    Type of the Object 

    When citing the name of an object, state what kind of object it is.

    Rationale: Otherwise no one will know what “foo.bar.baz” refers to.

I'm not sure whether adding that would be sufficient to make these
intelligible, but surely it would help.  I think your first example
would come out like

    label e of property(?) e of property graph create_property_graph_tests.gt

			regards, tom lane

[1] https://www.postgresql.org/docs/current/error-style-guide.html#ERROR-STYLE-GUIDE-OBJECT-TYPE

view thread (1526+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Fix DROP PROPERTY GRAPH "unsupported object class" error
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox