public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ashutosh Bapat <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Alex Guo <[email protected]>
Cc: Bertrand Drouvot <[email protected]>
Cc: [email protected]
Subject: Re: Fix DROP PROPERTY GRAPH "unsupported object class" error
Date: Wed, 10 Jun 2026 16:30:24 +0530
Message-ID: <CAExHW5vZN5ADVaXj0X9Xq1gnShUr4SxjXTL5F4MwjzcD65sJzA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <afmHd5vSCJtMFueS@bdtpg>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAExHW5sR8tY1JBoG4MGH3pU9A5wq1m4mHZOt0c8wXjcVqZ13sw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAExHW5uMGdnmxiiWNRNZ+PEaZfec9fVQK8hZ7Vm8vUuQwYNbcg@mail.gmail.com>
	<[email protected]>

On Wed, Jun 10, 2026 at 10:49 AM Michael Paquier <[email protected]> wrote:
>
> On Wed, Jun 10, 2026 at 09:28:56AM +0530, Ashutosh Bapat wrote:
> > Here's a patch fixing it.
>
> Based on the definitions of pglpgid/pgepgid/pgppgid (property graph
> relations), pgelelid (property graph element) and plpellabelid
> (property graph element label), that looks better.  I am still puzzled
> regarding the choice of "label" in the patch for plpellabelid while it
> is an "element label" based on the way it is stored in its catalog,
> with the catalog matching the object being named "property graph
> element label".
>

Which specific string you are referring to?

property graph element label  |        |      | e of element e of
property graph create_property_graph_tests.gt - that doesn't have a
bare label in there

probably the next one
property graph label property |        |      | a of label v1 of
element v1 of property graph create_property_graph_tests.gt

The term "element" comes later "label v1 of element v1".   There's
nothing in the standard called "element label". That term is an
artifact of our implementation. I think "label v1 of element v1" reads
better and follows the standard compared to "element label v1 of
element v1".

There's also a precedent of not using exact catalog names. In case of
user mapping we say " %s of server ...", we don't use "foreign server"
there even though the object is called "foreign server" and the
catalog is pg_foreign_server.

-- 
Best Wishes,
Ashutosh Bapat

view thread (1520+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Fix DROP PROPERTY GRAPH "unsupported object class" error
  In-Reply-To: <CAExHW5vZN5ADVaXj0X9Xq1gnShUr4SxjXTL5F4MwjzcD65sJzA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox