pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <jchampion@timescale.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Log details for client certificate failures
Date: Wed, 20 Jul 2022 18:15:07 -0400
Message-ID: <2007344.1658355307@sss.pgh.pa.us> (raw)
In-Reply-To: <CAAWbhmhGOh_1C6x1A8K5hsMuSeOF5hxQ4ZMGkFhqmVTZ0otzRQ@mail.gmail.com>
References: <2878aee8-a4a6-8078-9740-efe90fcf8328@timescale.com>
	<20220715211914.c5oasfknx2njndov@awork3.anarazel.de>
	<1d3d62a0-2d7f-4592-bf76-ba59a77e61cc@timescale.com>
	<20220715234519.7o4mlpxapmqmv6p7@awork3.anarazel.de>
	<CAAWbhmiH2dPpRUnpS6pe9Fge--gj_az4ra2AJO1JvTKeiFuAug@mail.gmail.com>
	<20220719161432.qha3s76vyc6k4v5m@awork3.anarazel.de>
	<c0eca922-59db-ad5c-193f-09bc36b92468@timescale.com>
	<1212792.1658248783@sss.pgh.pa.us>
	<20220719170954.nshvmok3tymxdpl3@awork3.anarazel.de>
	<CAAWbhmiVZgfAUc=BuahotfHokWuJXLD6KQs8gYVvp_twFgQ-xg@mail.gmail.com>
	<20220719223823.pj4z36ce3zb27qdb@alap3.anarazel.de>
	<CAAWbhmhGOh_1C6x1A8K5hsMuSeOF5hxQ4ZMGkFhqmVTZ0otzRQ@mail.gmail.com>

Jacob Champion <jchampion@timescale.com> writes:
> The guc_strdup() approach really reduces the amount of code, so that's
> what I did in v3. I'm not following why we need to return NULL on
> failure, though -- both palloc() and guc_malloc() ERROR on failure, so
> is it okay to keep those semantics the same?

guc_malloc's behavior varies depending on elevel.  It's *not*
equivalent to palloc.

			regards, tom lane





view thread (54+ messages)  latest in thread

Message-ID: <2007344.1658355307@sss.pgh.pa.us>
Permalink:  ../2007344.1658355307@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2007344.1658355307@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, jchampion@timescale.com, andres@anarazel.de, peter.eisentraut@enterprisedb.com
  Subject: Re: [PATCH] Log details for client certificate failures
  In-Reply-To: <2007344.1658355307@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox