pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <jchampion@timescale.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Log details for client certificate failures
Date: Tue, 19 Jul 2022 12:39:43 -0400
Message-ID: <1212792.1658248783@sss.pgh.pa.us> (raw)
In-Reply-To: <c0eca922-59db-ad5c-193f-09bc36b92468@timescale.com>
References: <059e67f5-3769-24c8-f460-4e5d87af529a@enterprisedb.com>
	<0167a8c5-1754-9121-b994-0719a6493a21@timescale.com>
	<20220715191156.jecddreykoakdljm@awork3.anarazel.de>
	<ca6eb74e-aafc-f7cc-50fd-a6b33bca858b@timescale.com>
	<20220715203500.vanqxt23bmufjais@awork3.anarazel.de>
	<2878aee8-a4a6-8078-9740-efe90fcf8328@timescale.com>
	<20220715211914.c5oasfknx2njndov@awork3.anarazel.de>
	<1d3d62a0-2d7f-4592-bf76-ba59a77e61cc@timescale.com>
	<20220715234519.7o4mlpxapmqmv6p7@awork3.anarazel.de>
	<CAAWbhmiH2dPpRUnpS6pe9Fge--gj_az4ra2AJO1JvTKeiFuAug@mail.gmail.com>
	<20220719161432.qha3s76vyc6k4v5m@awork3.anarazel.de>
	<c0eca922-59db-ad5c-193f-09bc36b92468@timescale.com>

Jacob Champion <jchampion@timescale.com> writes:
> On 7/19/22 09:14, Andres Freund wrote:
>> IMO this should replace the existing ascii escape function instead.

> That will affect the existing behavior of application_name and
> cluster_name; is that acceptable?

I think Andres' point is exactly that these should all act alike.

Having said that, I struggle to see why we are panicking about badly
encoded log data from this source while blithely ignoring the problems
posed by non-ASCII role names, database names, and tablespace names.

			regards, tom lane





view thread (54+ messages)  latest in thread

Message-ID: <1212792.1658248783@sss.pgh.pa.us>
Permalink:  ../1212792.1658248783@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1212792.1658248783@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, jchampion@timescale.com, andres@anarazel.de, peter.eisentraut@enterprisedb.com
  Subject: Re: [PATCH] Log details for client certificate failures
  In-Reply-To: <1212792.1658248783@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox