pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Dan Ports <drkp@csail.mit.edu>
To: YAMAMOTO Takashi <yamt@mwd.biglobe.ne.jp>
Cc: Kevin.Grittner@wicourts.gov
Cc: pgsql-hackers@postgresql.org
Subject: Re: SSI bug?
Date: Thu, 17 Feb 2011 14:45:22 -0500
Message-ID: <20110217194522.GA98448@csail.mit.edu> (raw)
In-Reply-To: <20110216221335.C9A2119CF21@mail.netbsd.org>
References: <4D592869020000250003A99A@gw.wicourts.gov>
	<20110216221335.C9A2119CF21@mail.netbsd.org>

On Wed, Feb 16, 2011 at 10:13:35PM +0000, YAMAMOTO Takashi wrote:
> i got the following SEGV when runnning vacuum on a table.
> (the line numbers in predicate.c is different as i have local modifications.)
> oldlocktag.myTarget was NULL.
> it seems that TransferPredicateLocksToNewTarget sometimes use stack garbage
> for newpredlocktag.myTarget.  vacuum on the table succeeded with the attached
> patch.  the latter part of the patch was necessary to avoid targetList
> corruption, which later seems to make DeleteChildTargetLocks loop inifinitely.

Oops. Those are both definitely bugs (and my fault). Your patch looks
correct. Thanks for catching that!

Dan

-- 
Dan R. K. Ports              MIT CSAIL                http://drkp.net/



view thread (71+ messages)  latest in thread

Message-ID: <20110217194522.GA98448@csail.mit.edu>
Permalink:  ../20110217194522.GA98448@csail.mit.edu/
Also on:    postgresql.org/message-id/20110217194522.GA98448@csail.mit.edu

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: drkp@csail.mit.edu, yamt@mwd.biglobe.ne.jp, Kevin.Grittner@wicourts.gov
  Subject: Re: SSI bug?
  In-Reply-To: <20110217194522.GA98448@csail.mit.edu>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox