pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Andres Freund <andres@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: foreign key locks
Date: Wed, 14 Nov 2012 13:27:26 -0300
Message-ID: <20121114162726.GE5161@alvh.no-ip.org> (raw)
In-Reply-To: <20121114152347.GA5161@alvh.no-ip.org>
References: <4FEAB90A0200002500048B7D@gw.wicourts.gov>
	<1346389151-sup-8379@alvh.no-ip.org>
	<20121018195820.GO3763@alvh.no-ip.org>
	<201210270006.54728.andres@2ndquadrant.com>
	<20121114152347.GA5161@alvh.no-ip.org>

Alvaro Herrera wrote:

> > * In heap_lock_tuple's  XMAX_IS_MULTI case
> > 
> > [snip]
> > 
> > why is it membermode > mode and not membermode >= mode?
> 
> Uh, that's a bug.  Fixed.  As noticed in the comment above that snippet,
> there was a deadlock possible here.  Maybe I should add a test to ensure
> this doesn't happen.

Done:
https://github.com/alvherre/postgres/commit/df2847e38198e99f57e52490e1e9391ebb70d770

(I don't think this is worth a v24 submission).

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

view thread (74+ messages)  latest in thread

Message-ID: <20121114162726.GE5161@alvh.no-ip.org>
Permalink:  ../20121114162726.GE5161@alvh.no-ip.org/
Also on:    postgresql.org/message-id/20121114162726.GE5161@alvh.no-ip.org

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@2ndquadrant.com, andres@2ndquadrant.com
  Subject: Re: foreign key locks
  In-Reply-To: <20121114162726.GE5161@alvh.no-ip.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox