pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: David Fetter <david@fetter.org>
To: Simon Riggs <simon@2ndQuadrant.com>
Cc: Kohei KaiGai <kaigai@kaigai.gr.jp>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Florian Pflug <fgp@phlo.org>
Cc: PgHacker <pgsql-hackers@postgresql.org>
Subject: Re: [v9.3] Row-Level Security
Date: Mon, 3 Dec 2012 08:09:35 -0800
Message-ID: <20121203160935.GB16951@fetter.org> (raw)
In-Reply-To: <CA+U5nML-c6Hv4ME4xM_Es7f4e9A04vgr_8VGXAK7sBx602T52Q@mail.gmail.com>
References: <CADyhKSXHQxKYpnm4VizVnh=6Gv-TnxbjnucjWaH1am8zpvXY0Q@mail.gmail.com>
	<CADyhKSUFcMcwup1=ydvwghiy21Vn_OGzO-rX-VCBO1CSDNNTMQ@mail.gmail.com>
	<20121018181956.GL3763@alvh.no-ip.org>
	<CA+TgmoY6m-HCQfX8Qz8V5c9wbzqFU7GSpWaBDLcpb4o2sWtcEQ@mail.gmail.com>
	<CADyhKSXsN5xGFPsx8fXkOxkuaSePLFd4BFcdxvE5KfTK6wFBmw@mail.gmail.com>
	<CADyhKSUBRFuXpgy=NjMgX2H57aRh4pQ7cDhLcpn=ThCGCwaPgg@mail.gmail.com>
	<CADyhKSU4jOAwZ-tWEeBUFzis2dN9NmwxWwLgYnHdfYWF25p5-Q@mail.gmail.com>
	<20121203152521.GA16951@fetter.org>
	<CADyhKSWDXFx3iy8UzhC1x4ubcEtOp7q+qK5CwD-uFanHCe22Xw@mail.gmail.com>
	<CA+U5nML-c6Hv4ME4xM_Es7f4e9A04vgr_8VGXAK7sBx602T52Q@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On Mon, Dec 03, 2012 at 03:41:47PM +0000, Simon Riggs wrote:
> On 3 December 2012 15:36, Kohei KaiGai <kaigai@kaigai.gr.jp> wrote:
> > 2012/12/3 David Fetter <david@fetter.org>:
> >> On Sun, Nov 25, 2012 at 03:20:28PM +0100, Kohei KaiGai wrote:
> >>> > However, UPDATE / DELETE support is not perfect right now.
> >>> > In case when we try to update / delete a table with inherited
> >>> > children and RETURNING clause was added, is loses right
> >>> > references to the pseudo columns, even though it works fine
> >>> > without inherited children.
> >>> >
> >>> The attached patch fixed this known problem.
> >>
> >> This patch no longer applies to git master.  Any chance of a rebase?
> >>
> > OK, I'll rebese it.
> 
> No chunk failures, its just fuzz.

I must have done something wrong.

I downloaded the patch from the web email archives, then ran "git
apply" on it, and got this:

$ git apply ../pgsql-v9.3-row-level-security.rw.v7.patch
../pgsql-v9.3-row-level-security.rw.v7.patch:806: space before tab in indent.
         * row-level security policy
../pgsql-v9.3-row-level-security.rw.v7.patch:1909: trailing whitespace.
 * would be given. Because the sub-query has security barrier flag, 
../pgsql-v9.3-row-level-security.rw.v7.patch:2886: trailing whitespace.
 did | cid | dlevel |      dauthor      |        dtitle         
../pgsql-v9.3-row-level-security.rw.v7.patch:2899: trailing whitespace.
 cid | did | dlevel |      dauthor      |        dtitle         |      cname      
../pgsql-v9.3-row-level-security.rw.v7.patch:2918: trailing whitespace.
 did | cid | dlevel |      dauthor      |        dtitle         
error: patch failed: src/backend/commands/copy.c:34
error: src/backend/commands/copy.c: patch does not apply

What did I do wrong here?

Cheers,
David.
-- 
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (165+ messages)  latest in thread

Message-ID: <20121203160935.GB16951@fetter.org>
Permalink:  ../20121203160935.GB16951@fetter.org/
Also on:    postgresql.org/message-id/20121203160935.GB16951@fetter.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: david@fetter.org, simon@2ndQuadrant.com, kaigai@kaigai.gr.jp, robertmhaas@gmail.com, alvherre@2ndquadrant.com, dean.a.rasheed@gmail.com, tgl@sss.pgh.pa.us, fgp@phlo.org
  Subject: Re: [v9.3] Row-Level Security
  In-Reply-To: <20121203160935.GB16951@fetter.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox