From: Cédric Villemain <cedric@2ndquadrant.com>
To: pgsql-hackers@postgresql.org
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Andrew Dunstan <andrew@dunslane.net>
Subject: Re: Bugfix and new feature for PGXS
Date: Thu, 20 Jun 2013 13:18:31 +0200
Message-ID: <201306201318.31428.cedric@2ndquadrant.com> (raw)
In-Reply-To: <51C29153.60708@2ndquadrant.com>
References: <201306181552.36673.cedric@2ndquadrant.com>
<1371698781.13762.48.camel@vanquo.pezone.net>
<51C29153.60708@2ndquadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
> Opinions all?
>
> * Give up on being able to use one extension's header from another
> entirely, except in the special case of in-tree builds
There are already a good number of use cases with only hstore and intarray,
I'm in favor of this feature.
> * Install install-enabled contrib headers into an include/contrib/
> that's always on the pgxs include path, so you can still just "#include
> hstore.h" . For in-tree builds, explicit add other modules' contrib dirs
> as Peter has done in the proposed plperl_hstore and plpython_hstore.
> (Use unqualified names).
I don't like the idea to share a flat directory with different header files,
filenames can overlap.
> * Install install-enabled contrib headers to
> include/contrib/[modulename]/ . Within the module, use the unqualified
> header name. When referring to it from outside the module, use #include
> "contrib/modulename/header.h". Add $(top_srcdir) to the include path
> when building extensions in-tree.
not either, see my other mail. we still #include hstore.h when we want, we
just add that the header so it is available for PGXS builds. Contrib Makefile
still need to -I$(includedir_contrib)/hstore. What's new is that the header is
installed, not that we don't have to set FLAGS.
> Personally, I'm all for just using the local path when building the
> module, and the qualified path elsewhere. It requires only a relatively
> simple change, and I don't think that using "hstore.h" within hstore,
> and "contrib/hstore/hstore.h" elsewhere is of great concern.
--
Cédric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - Développement, Expertise et Formation
Attachments:
signature.asc (application/pgp-signature, 489B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: cedric@2ndquadrant.com, craig@2ndquadrant.com, peter_e@gmx.net, andrew@dunslane.net
Subject: Re: Bugfix and new feature for PGXS
In-Reply-To: <201306201318.31428.cedric@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox