From: Cédric Villemain <cedric@2ndquadrant.com>
To: pgsql-hackers@postgresql.org
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Josh Berkus <josh@agliodbs.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Bugfix and new feature for PGXS
Date: Fri, 12 Jul 2013 23:50:18 +0200
Message-ID: <201307122350.23726.cedric@2ndquadrant.com> (raw)
In-Reply-To: <51DB171F.2090108@dunslane.net>
References: <201306181552.36673.cedric@2ndquadrant.com>
<51DB15CB.9050102@agliodbs.com>
<51DB171F.2090108@dunslane.net>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Le lundi 8 juillet 2013 21:46:39, Andrew Dunstan a écrit :
> On 07/08/2013 03:40 PM, Josh Berkus wrote:
> > On 07/04/2013 06:18 AM, Andrew Dunstan wrote:
> >> On 07/04/2013 09:14 AM, Cédric Villemain wrote:
> >>> ah yes, good catch, I though .control file were unique per contrib,
> >>> but there aren't.
> >>
> >> It's already been fixed.
> >
> > Does it look like this patch will get into committable shape in the next
> > couple of days?
>
> I think everything has been committed - as I think the CF app shows. The
> only thing left in this srea from Cédric is the insallation of headers,
> which Peter is down to review and is in "Waiting on Author" status.
which is returned with feedback now, I can update if someone really wants it.
> We are owed a docco patch though.
Simple one, attached.
I didn't document USE_VPATH, not sure how to explain that clearly.
--
Cédric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - Développement, Expertise et Formation
Attachments:0001-add-documentation-for-commit-6697aa2.patch (text/x-patch, 2.1K) download
From 1380870e061362b871c375c25517005f82358dc3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Villemain?= <cedric@2ndquadrant.fr>
Date: Fri, 12 Jul 2013 23:39:11 +0200
Subject: [PATCH] add documentation for commit 6697aa2
Document that PGXS offers VPATH build and add a sample like in
installation.sgml
Also update the part about the PGXS global makefile inclusion.
It was suggested to put it at the end, but if the Makefile contains
a target before the include of pgxs then the default all: target is
removed and the Makefile must define all: itself.
---
doc/src/sgml/extend.sgml | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/doc/src/sgml/extend.sgml b/doc/src/sgml/extend.sgmlindex 60fa1a8..8f082e4 100644--- a/doc/src/sgml/extend.sgml+++ b/doc/src/sgml/extend.sgml@@ -935,7 +935,7 @@ include $(PGXS)
To use the <acronym>PGXS</acronym> infrastructure for your extension,
you must write a simple makefile.
In the makefile, you need to set some variables
- and finally include the global <acronym>PGXS</acronym> makefile.+ and include the global <acronym>PGXS</acronym> makefile.
Here is an example that builds an extension module named
<literal>isbn_issn</literal>, consisting of a shared library containing
some C code, an extension control file, a SQL script, and a documentation
@@ -1161,6 +1161,19 @@ include $(PGXS)
or on the <literal>make</literal> command line.
</para>
+ <para>+ You can also run <literal>make</literal> in a directory outside the source+ tree of your extension, if you want to keep the build directory separate.+ This procedure is also called a+ <indexterm><primary>VPATH</primary></indexterm><firstterm>VPATH</firstterm>+ build. Here's how:+ <screen>+ <userinput>mkdir build_dir</userinput>+ <userinput>cd build_dir</userinput>+ <userinput>make -f /path/to/extension/source/tree/Makefile</userinput>+ <userinput>make -f /path/to/extension/source/tree/Makefile install</userinput>+ </screen>+ </para>
<caution>
<para>
Changing <varname>PG_CONFIG</varname> only works when building
--
1.7.10.4
signature.asc (application/pgp-signature, 489B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: cedric@2ndquadrant.com, andrew@dunslane.net, josh@agliodbs.com, robertmhaas@gmail.com, peter_e@gmx.net, craig@2ndquadrant.com
Subject: Re: Bugfix and new feature for PGXS
In-Reply-To: <201307122350.23726.cedric@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox