From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: hlinnaka@iki.fi, CharSyam <charsyam@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Typo patch
Date: Wed, 20 May 2015 14:37:47 -0300
Message-ID: <20150520173747.GA5885@postgresql.org> (raw)
In-Reply-To: <24243.1432141520@sss.pgh.pa.us>
References: <CAMrLSE6u25W50SgnOdhP4QyJif+fHMp7dkX8MLnxeTiaAhEaSQ@mail.gmail.com>
<555CBB19.8090206@iki.fi>
<24243.1432141520@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Tom Lane wrote:
> Heikki Linnakangas <hlinnaka@iki.fi> writes:
> > Thanks, committed. Except for this one:
>
> > - * *Only* a frozen-for-read tape can be seeked.
> > + * *Only* a frozen-for-read tape can be sought.
>
> > It's true that the past tense of "seek" is "sought", but it feels a bit
> > weird to me in this context. This is a comment on a function called
> > "<blah blah>seek", and it's not clear to me that it should conjugate
> > like the normal "seek" verb.
>
> I agree that "sought" is not the word to use here, but the existing
> wording isn't very good English either. Perhaps "Seeking is only allowed
> on frozen-for-read tapes"?
It would be great if you could find a solution for words such as
"shutdowned" or "backuped". (I don't know that we use the latter in our
code, but I've seen it around. The former we even have in an enum
somewhere.)
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, charsyam@gmail.com
Subject: Re: Typo patch
In-Reply-To: <20150520173747.GA5885@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox