From: Noah Misch <noah@leadboat.com>
To: Andres Freund <andres@anarazel.de>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: pgsql-core <pgsql-core@postgresql.org>
Subject: Re: Restore-reliability mode
Date: Wed, 10 Jun 2015 01:57:22 -0400
Message-ID: <20150610055722.GB218346@tornado.leadboat.com> (raw)
In-Reply-To: <20150603141837.GD18006@awork2.anarazel.de>
References: <CA+Tgmoa6hekDGenr29TG_K4bH7rxLEM9RU+5KDAiY+SiAsFhew@mail.gmail.com>
<20150529223321.GB6535@alap3.anarazel.de>
<CA+TgmoYSO0a9YDe2bhpZoPgO4m62CyQL26LRkCQ8=vrQ8ZwdXA@mail.gmail.com>
<12510.1432958887@sss.pgh.pa.us>
<CA+TgmoYovkev0xXnxaTD8vnt=M9Cn+RmOkVEouqwj6_9JLkzLw@mail.gmail.com>
<20150530154559.GA25053@momjian.us>
<20150530204727.GJ13944@alap3.anarazel.de>
<20150531024845.GB13697@momjian.us>
<20150603135049.GA74753@tornado.leadboat.com>
<20150603141837.GD18006@awork2.anarazel.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On Wed, Jun 03, 2015 at 04:18:37PM +0200, Andres Freund wrote:
> On 2015-06-03 09:50:49 -0400, Noah Misch wrote:
> > Second, I would define the subject matter as "bug fixes, testing and
> > review", not "restructuring, testing and review." Different code
> > structures are clearest to different hackers. Restructuring, on
> > average, adds bugs even more quickly than feature development adds
> > them.
>
> I can't agree with this. While I agree with not doing large
> restructuring for 9.5, I think we can't affort not to refactor for
> clarity, even if that introduces bugs. Noticeable parts of our code have
> to frequently be modified for new features and are badly structured at
> the same time. While restructuring will may temporarily increase the
> number of bugs in the short term, it'll decrease the number of bugs long
> term while increasing the number of potential contributors and new
> features. That's obviously not to say we should just refactor for the
> sake of it.
I think I agree with everything after your first sentence. I liked your
specific proposal to split StartupXLOG(), but making broad-appeal
restructuring proposals is hard. I doubt we would get good results by casting
a wide net for restructuring ideas. Automated testing has a lower barrier to
entry and is far less liable to make things worse instead of better. I can
hope for good results from a TestSuiteFest, but not from a RestructureFest.
That said, if folks initiate compelling restructure proposals, we should be
willing to risk bugs from them like we risk bugs to acquire new features.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, andres@anarazel.de, bruce@momjian.us, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, sfrost@snowman.net, magnus@hagander.net, pgsql-core@postgresql.org
Subject: Re: Restore-reliability mode
In-Reply-To: <20150610055722.GB218346@tornado.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox