pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Making tab-complete.c easier to maintain
Date: Wed, 30 Dec 2015 11:21:18 -0300
Message-ID: <20151230142118.GV58441@alvherre.pgsql> (raw)
In-Reply-To: <CAB7nPqTe_HvKQY31W5bNyyTHRn23PPQ-7hwJqNKL5LExT4D4oQ@mail.gmail.com>
References: <CAB7nPqS=UHm2QyJtx+kyyHb4WH09vK3NVUqJVFBotQAQx5hD4g@mail.gmail.com>
	<CAEepm=2vMAESiiind-jbQK-sAibLr1440E8pj_KmWYO8XBtiRA@mail.gmail.com>
	<1851.1450471370@sss.pgh.pa.us>
	<CAB7nPqS0-TjcwUWM4R+-77aCrAz9B6a+S_d973CeJvfLm7r-Tg@mail.gmail.com>
	<21460.1450560248@sss.pgh.pa.us>
	<CAB7nPqQpDTQHn3s20-xLP93Cs3LBpCtedrSO1yN8kRoMhSg7eg@mail.gmail.com>
	<CAB7nPqQbBxBWGuVZ1a4ZZDic=D3NJg=gpo18UtND0_aCV0eiRw@mail.gmail.com>
	<CAEepm=34Ba7rDa-mASkxmaD87aW21juALF58B6MRwKc54JYFmA@mail.gmail.com>
	<CAB7nPqQGCXGjrrDQo2ZB9FhvzrZSZk0NoFvhrsKh8-gwuU4wmQ@mail.gmail.com>
	<CAB7nPqTe_HvKQY31W5bNyyTHRn23PPQ-7hwJqNKL5LExT4D4oQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Michael Paquier wrote:

> OK, here are new patches.
> - 0001 switches a bunch of TailMatches to Matches. Do we want to care
> about the case where a schema is created following by a bunch of
> objects? I mean stuff like "CREATE SCHEMA hoge CREATE TABLE ..." where
> the current completion would work fine. The performance gains seem
> worth it compared to the number of people actually using it, the point
> has just not been raised yet.

I'd rather have the completion work for that case than get a few
microseconds speedup.  As far as I recall, it's only four commands that
must retain the old coding.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (86+ messages)  latest in thread

Message-ID: <20151230142118.GV58441@alvherre.pgsql>
Permalink:  ../20151230142118.GV58441@alvherre.pgsql/
Also on:    postgresql.org/message-id/20151230142118.GV58441@alvherre.pgsql

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@2ndquadrant.com, michael.paquier@gmail.com, thomas.munro@enterprisedb.com, tgl@sss.pgh.pa.us, horiguchi.kyotaro@lab.ntt.co.jp, jeff.janes@gmail.com
  Subject: Re: Making tab-complete.c easier to maintain
  In-Reply-To: <20151230142118.GV58441@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox