pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Aleksander Alekseev <a.alekseev@postgrespro.ru>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Patch: fix lock contention for HASHHDR.mutex
Date: Wed, 27 Jan 2016 14:45:42 +0300
Message-ID: <20160127144542.224c0741@fujitsu> (raw)
In-Reply-To: <CAFiTN-srHqMXRU-EO0EnzVEtwAqyqx=SX7YXWkdRotvN0SU_dw@mail.gmail.com>
References: <20151230160137.034371e0@fujitsu>
	<20160112001642.GA802875@alvherre.pgsql>
	<20160112112005.26675392@fujitsu>
	<CAFiTN-vJ2M1tn0yrFsOUn1-anQfzpB2n1SyEA_PBu4zk4KCe_w@mail.gmail.com>
	<20160122131432.2f11dac4@fujitsu>
	<CAFiTN-srHqMXRU-EO0EnzVEtwAqyqx=SX7YXWkdRotvN0SU_dw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

> > This patch affects header files. By any chance didn't you forget to
> > run `make clean` after applying it? As we discussed above, when you
> > change .h files autotools doesn't rebuild dependent .c files:
> >
> 
> Yes, actually i always compile using "make clean;make -j20; make
> install" If you want i will run it again may be today or tomorrow and
> post the result.
> 
> 

Most likely HASHHDR.mutex is not only bottleneck in your case so my
patch doesn't help much. Unfortunately I don't have access to any
POWER8 server so I can't investigate this issue. I suggest to use a
gettimeofday trick I described in a first message of this thread. Its
time consuming but it gives a clear understanding which code is keeping
a lock.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (74+ messages)  latest in thread

Message-ID: <20160127144542.224c0741@fujitsu>
Permalink:  ../20160127144542.224c0741@fujitsu/
Also on:    postgresql.org/message-id/20160127144542.224c0741@fujitsu

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: a.alekseev@postgrespro.ru, dilipbalaut@gmail.com
  Subject: Re: Patch: fix lock contention for HASHHDR.mutex
  In-Reply-To: <20160127144542.224c0741@fujitsu>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox