From: Stephen Frost <sfrost@snowman.net>
To: Robbie Harwood <rharwood@redhat.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH v6] GSSAPI encryption support
Date: Tue, 15 Mar 2016 15:54:36 -0400
Message-ID: <20160315195436.GE3127@tamriel.snowman.net> (raw)
In-Reply-To: <jlgtwk7il5x.fsf@thriss.redhat.com>
References: <jlg1tgq1ktm.fsf@thriss.redhat.com>
<jlgegbkmvxl.fsf@thriss.redhat.com>
<56E81852.1060005@pgmasters.net>
<CAB7nPqTjnLWBOepE+Oy5WZBjcq7sRJ9_uKvvXuThst9dvBxkZQ@mail.gmail.com>
<jlgtwk7il5x.fsf@thriss.redhat.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Robbie,
* Robbie Harwood (rharwood@redhat.com) wrote:
> Michael Paquier <michael.paquier@gmail.com> writes:
> > - maj_stat = gss_accept_sec_context(
> > - &min_stat,
> > + maj_stat = gss_accept_sec_context(&min_stat,
> >
> > This is just noise.
>
> You're not wrong, though I do think it makes the code more readable by
> enforcing style and this is a "cleanup" commit. I'll take it out if it
> bothers you.
First, thanks much for working on this, I've been following along the
discussions and hope to be able to help move it to commit, once it's
ready.
Secondly, generally, speaking, we prefer that 'cleanup' type changes
(particularly whitespace-only ones) are in independent commits which are
marked as just whitespace/indentation changes. We have a number of
organizations which follow our code changes and it makes it more
difficult on them to include whitespace/indentation changes with code
changes.
Thanks!
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, rharwood@redhat.com, michael.paquier@gmail.com, david@pgmasters.net
Subject: Re: [PATCH v6] GSSAPI encryption support
In-Reply-To: <20160315195436.GE3127@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox