From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Subject: Re: pgbench stats per script & other stuff
Date: Tue, 29 Mar 2016 14:58:17 -0300
Message-ID: <20160329175817.GA883652@alvherre.pgsql> (raw)
In-Reply-To: <20160329175516.GA881582@alvherre.pgsql>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Alvaro Herrera wrote:
> In doing this, I noticed that the latency output is wrong if you use -T
> instead of -t; it always says the latency is zero because "duration" is
> zero. I suppose it should be like in the attached instead. At the same
> time, it says "latency average: XYZ" instead of "latency average = XYZ"
> as in printSimpleStats, which doesn't look terribly important. But the
> line appears in the SGML docs.
Patch actually attached here.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackersAttachments:
[text/x-diff] pgbench-latency.patch (719B, ../20160329175817.GA883652@alvherre.pgsql/2-pgbench-latency.patch)
download | inline diff:diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.cindex 52d1223..5cb5906 100644--- a/src/bin/pgbench/pgbench.c+++ b/src/bin/pgbench/pgbench.c@@ -3152,10 +3152,13 @@ printResults(TState *threads, StatsData *total, instr_time total_time,
if (throttle_delay || progress || latency_limit)
printSimpleStats("latency", &total->latency);
- else+ else if (duration > 0)
/* only an average latency computed from the duration is available */
- printf("latency average: %.3f ms\n",+ printf("latency average: %.3f ms",
1000.0 * duration * nclients / total->cnt);
+ else+ printf("latency average: %.3f ms",+ 1000.0 * time_include * nclients / total->cnt);
if (throttle_delay)
{
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, coelho@cri.ensmp.fr, jeff.janes@gmail.com
Subject: Re: pgbench stats per script & other stuff
In-Reply-To: <20160329175817.GA883652@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox