From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pg_dump -s -b
Date: Sat, 19 Nov 2016 12:33:16 -0500
Message-ID: <20161119173316.GA13284@tamriel.snowman.net> (raw)
In-Reply-To: <24987.1479576007@sss.pgh.pa.us>
References: <20161119170835.GZ13284@tamriel.snowman.net>
<24987.1479576007@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> IMO, blobs are data, so those behaviors are correct. The docs should
> be fixed to match the code.
Works for me.
Thoughts on the attached?
Thanks!
Stephen
Attachments:
[text/x-diff] pg_dump_blobs_doc_fix.patch (1.2K, ../20161119173316.GA13284@tamriel.snowman.net/2-pg_dump_blobs_doc_fix.patch)
download | inline diff:diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgmlnew file mode 100644index 371a614..04b3124
*** a/doc/src/sgml/ref/pg_dump.sgml
--- b/doc/src/sgml/ref/pg_dump.sgml
*************** PostgreSQL documentation
*** 138,145 ****
<para>
Include large objects in the dump. This is the default behavior
except when <option>--schema</>, <option>--table</>, or
! <option>--schema-only</> is specified, so the <option>-b</>
! switch is only useful to add large objects to selective dumps.
</para>
</listitem>
</varlistentry>
--- 138,148 ----
<para>
Include large objects in the dump. This is the default behavior
except when <option>--schema</>, <option>--table</>, or
! <option>--schema-only</> is specified. The <option>-b</>
! switch is therefore only useful to add large objects to dumps
! where a specific schema or table has been requested. Note that
! blobs are considered data and therefore will be included when
! --data-only is used, but not when --schema-only is.
</para>
</listitem>
</varlistentry>
[application/pgp-signature] signature.asc (818B, ../20161119173316.GA13284@tamriel.snowman.net/3-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us
Subject: Re: pg_dump -s -b
In-Reply-To: <20161119173316.GA13284@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox