From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pg_recvlogical.c doesn't build with --disable-integer-datetimes
Date: Fri, 17 Feb 2017 15:13:48 -0300
Message-ID: <20170217181348.a5pnflupslw2t6xx@alvherre.pgsql> (raw)
In-Reply-To: <29306.1487352105@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Tom Lane wrote:
> My own compilers don't generate errors either, only warnings. Maybe
> we could catch this sort of thing mechanically with a critter configured
> with -Werror as well as --disable-integer-datetimes, but I'm a tad
> hesitant to have a buildfarm machine configured with -Werror. We'd
> be raising the stakes quite a bit on keeping the code warning-free
> for a specific compiler that might prove to be picky in silly ways.
>
> But if it were a pretty mainstream compiler that hadn't shown much
> evidence of wanting to throw useless warnings, maybe that's fine.
>
> Thoughts?
Note that Thomas' compiler was using -Werror.
I think we're at a point where one gcc plus one clang animals set up
with -Werror would be a good thing to have, and keep green. In
practice, this list fulfills the role of such a compiler, only with much
higher communication overhead.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, thomas.munro@enterprisedb.com, andrew@dunslane.net
Subject: Re: pg_recvlogical.c doesn't build with --disable-integer-datetimes
In-Reply-To: <20170217181348.a5pnflupslw2t6xx@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox