pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Stephen Frost <sfrost@snowman.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: Make pg_stop_backup() archive wait optional
Date: Mon, 6 Mar 2017 12:53:13 -0500
Message-ID: <20170306175312.GX9812@tamriel.snowman.net> (raw)
In-Reply-To: <CA+TgmoZfjF2k6N8Rfga20bXxnRAttuz8N6dvxeOu=t3j0FYYsg@mail.gmail.com>
References: <758e3fd1-45b4-5e28-75cd-e9e7f93a4c02@pgmasters.net>
	<CAB7nPqRf6LnNN3TZZGi5DJ8sTWE5XekBSAj7E0CqsJ1nDGhiEA@mail.gmail.com>
	<35b7530c-68ce-7090-e13c-e39e4dac9bca@pgmasters.net>
	<CAB7nPqS-vH_Hk=+n63SHKS4ZrpknwNN9KMr9WkPZ9De=wU02Yg@mail.gmail.com>
	<967b90bd-6b65-a18a-5266-bfa9191c40e6@pgmasters.net>
	<CA+TgmoYCWfO2UM-t=HUMFJyxJywLDiLL0nAJpx88LKtvBvNECw@mail.gmail.com>
	<aa775a6f-059c-47dc-ef87-1f017073014b@pgmasters.net>
	<CA+TgmobfcE=fVoqhgWr6SFuhARdo6DY2Yz27eOevJnXr0ch1Lw@mail.gmail.com>
	<0f46c90e-2884-59be-69bf-8f467d4c9ba2@pgmasters.net>
	<CA+TgmoZfjF2k6N8Rfga20bXxnRAttuz8N6dvxeOu=t3j0FYYsg@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Robert, all,

* Robert Haas (robertmhaas@gmail.com) wrote:
> On Sat, Mar 4, 2017 at 9:12 AM, David Steele <david@pgmasters.net> wrote:
> > Yes, that makes sense.  Attached are two patches as requested:
> >
> > 01 - Just marks pg_stop_backup() variants as parallel restricted
> > 02 - Add the wait_for_archive param to pg_stop_backup().
> >
> > These apply cleanly on 272adf4.
> 
> Committed 01.  Nobody's offered an opinion about 02 yet, so I'm not
> going to commit that, but one minor nitpick:
> 
> +    WAL to be archived.  This behavior is only useful for backup
> +    software which independently monitors WAL archiving, otherwise WAL
> +    required to make the backup consistent might be missing and make the backup
> 
> I think this should really say "...which independently monitors WAL
> archiving.  Otherwise, WAL..."

Regarding 02, I certainly see that as valuable for the reasons which
David outlined in his initial email.  I can certainly take point on
getting it committed, but I wouldn't complain if someone else does
either.

Thanks!

Stephen

Attachments:

  [application/pgp-signature] signature.asc (818B, ../20170306175312.GX9812@tamriel.snowman.net/2-signature.asc)
  download

view thread (31+ messages)  latest in thread

Message-ID: <20170306175312.GX9812@tamriel.snowman.net>
Permalink:  ../20170306175312.GX9812@tamriel.snowman.net/
Also on:    postgresql.org/message-id/20170306175312.GX9812@tamriel.snowman.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: sfrost@snowman.net, robertmhaas@gmail.com, david@pgmasters.net, michael.paquier@gmail.com
  Subject: Re: PATCH: Make pg_stop_backup() archive wait optional
  In-Reply-To: <20170306175312.GX9812@tamriel.snowman.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox