From: Aleksander Alekseev <a.alekseev@postgrespro.ru>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Anastasia Lubennikova <lubennikovaav@gmail.com>
Cc: Peter Geoghegan <pg@heroku.com>
Cc: David Steele <david@pgmasters.net>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Subject: Re: WIP: Covering + unique indexes.
Date: Thu, 30 Mar 2017 22:27:06 +0300
Message-ID: <20170330192706.GA2565@e733.localdomain> (raw)
In-Reply-To: <CA+TgmoY0CU4s0w_8ZSBNJEqQ15jcFj5Lsx062s-518PjwAP85Q@mail.gmail.com>
References: <56168952.4010101@postgrespro.ru>
<46e1f13e-6887-3851-a525-f046029341eb@postgrespro.ru>
<20170324124709.22419.51178.pgcf@coridan.postgresql.org>
<c1f7c059-597f-44e8-7308-73d76ffd493c@sigaev.ru>
<CA+TgmoY0CU4s0w_8ZSBNJEqQ15jcFj5Lsx062s-518PjwAP85Q@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Hi Robert,
> Has anybody done some testing of this patch with the WAL consistency
> checker? Like, create some tables with indexes that have INCLUDE
> columns, set up a standby, enable consistency checking, pound the
> master, and see if the standby bails?
I've decided to run such a test. It looks like there is a bug indeed.
Steps to reproduce:
0. Apply a patch.
1. Build PostgreSQL using quick-build.sh [1]
2. Install master and replica using install.sh [2]
3. Download test.sql [3]
4. Run: `cat test.sql | psql`
5. In replica's logfile:
```
FATAL: inconsistent page found, rel 1663/16384/16396, forknum 0, blkno 1
```
> Has anybody tested this patch with amcheck? Does it break amcheck?
Amcheck doesn't complain.
[1] https://github.com/afiskon/pgscripts/blob/master/quick-build.sh
[2] https://github.com/afiskon/pgscripts/blob/master/install.sh
[3] http://afiskon.ru/s/88/93c544e6cf_test.sql
--
Best regards,
Aleksander Alekseev
Attachments:
[application/pgp-signature] signature.asc (832B, ../20170330192706.GA2565@e733.localdomain/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.alekseev@postgrespro.ru, robertmhaas@gmail.com, teodor@sigaev.ru, lubennikovaav@gmail.com, pg@heroku.com, david@pgmasters.net, peter.eisentraut@2ndquadrant.com
Subject: Re: WIP: Covering + unique indexes.
In-Reply-To: <20170330192706.GA2565@e733.localdomain>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox