From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: GCC 7 warnings
Date: Tue, 11 Apr 2017 14:57:08 -0300
Message-ID: <20170411175708.coshtfzejgaqhar2@alvherre.pgsql> (raw)
In-Reply-To: <14447.1491841559@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> > d) Replace most of the problematic code with psprintf() and dynamically
> > sized buffers.
>
> +1 for (c) as you have it. Later we might think about selectively
> doing (d), but it seems like more work for probably not much benefit.
Yeah -- also it's possible some of these code paths must not attempt to
palloc() for robustness reasons. I would go for c) only for now, and
only try d) for very specific cases where there are no such concerns.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com
Subject: Re: GCC 7 warnings
In-Reply-To: <20170411175708.coshtfzejgaqhar2@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox