From: Stephen Frost <sfrost@snowman.net>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Noah Misch <noah@leadboat.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
Date: Thu, 4 May 2017 00:19:04 -0400
Message-ID: <20170504041904.GD21223@tamriel.snowman.net> (raw)
In-Reply-To: <CA+HiwqFn=iGV_sg53CtX+kqmNGm7vdT7sbgzTNOfJ5w=O4H5zg@mail.gmail.com>
References: <20170420234334.GW9812@tamriel.snowman.net>
<9b7baae3-21b5-a730-1ec4-aee290d54518@lab.ntt.co.jp>
<20170425154247.GJ9812@tamriel.snowman.net>
<5cdfd834-695a-9c05-8fb4-cde08de21a9b@lab.ntt.co.jp>
<20170426143157.GA21223@tamriel.snowman.net>
<47e1d272-8ce0-dea8-2bb5-642efa95c337@lab.ntt.co.jp>
<20170427141726.GF21223@tamriel.snowman.net>
<696c2d04-80aa-57e2-c1c5-6df25e2bbed5@lab.ntt.co.jp>
<20170503030520.GR21223@tamriel.snowman.net>
<CA+HiwqFn=iGV_sg53CtX+kqmNGm7vdT7sbgzTNOfJ5w=O4H5zg@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Amit,
* Amit Langote (amitlangote09@gmail.com) wrote:
> On Wed, May 3, 2017 at 12:05 PM, Stephen Frost <sfrost@snowman.net> wrote:
> > * Amit Langote (Langote_Amit_f8@lab.ntt.co.jp) wrote:
> >> Attached updated patches.
> >
> > Please find an updated version which corrects the issue with
> > binary-upgrade of partitioned tables having partitions in other schemas,
> > along with a few other minor improvements.
> >
> > If you could take a look at it, I'd appreciate it. We already had a
> > test case in the pg_dump TAP tests for partitions existing in a schema
> > different from the partitioned table, but we weren't checking the
> > binary-upgrade case, so I've added a check to do that now. I'm sure
> > additional tests would be good to add and will take a look at doing that
> > tomorrow, but this hopefully closes at least the latest issue.
> >
> > Assuming this looks good to you, I'll push it tomorrow, possibly with
> > other minor adjustments and perhaps a few more tests.
>
> Your latest patch looks good to me.
Ok, great, thanks for taking a look at it. Too late for me to push it
tonight, so I'll do so tomorrow.
Thanks again!
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20170504041904.GD21223@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, amitlangote09@gmail.com, Langote_Amit_f8@lab.ntt.co.jp, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, noah@leadboat.com
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
In-Reply-To: <20170504041904.GD21223@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox