pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>
To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Robert Haas <robertmhaas@gmail.com>
Subject: Re: Bug in ExecModifyTable function and trigger issues for foreign tables
Date: Tue, 12 Sep 2017 18:26:22 +0300
Message-ID: <20170912182622.608b47c4@wp.localdomain> (raw)
In-Reply-To: <f8aa99d0-627d-32dc-fbc7-4e5943f9d652@lab.ntt.co.jp>
References: <20170514150525.0346ba72@postgrespro.ru>
	<CAFjFpRcQudmKYU4PJRN1-wp5K4aksupSoVpcRVAzES_49T=Vng@mail.gmail.com>
	<20170516150516.1b616230@wp.localdomain>
	<CAFjFpReeA3G3-U-FsR79zx_xFBVZc73hhWcH4OVWMb+ZFViRQg@mail.gmail.com>
	<dbf4b9ff-b0be-2396-7c79-d5763ae8a034@lab.ntt.co.jp>
	<f62d1797-2817-0f2e-eb7b-38da40504c8d@lab.ntt.co.jp>
	<a31f779e-9cb8-1ea5-71a6-bca6adbfa6a4@lab.ntt.co.jp>
	<20170615180548.5e142ddc@wp.localdomain>
	<0bc9c28b-96ca-c875-871e-16af6f53ecd9@lab.ntt.co.jp>
	<CAFjFpReUW9JhuyEq5mhi2Hrt3KpjHHP8LnWBZQhrHek3c0KGVQ@mail.gmail.com>
	<428f1672-df54-de01-91da-b57365193bf4@lab.ntt.co.jp>
	<d0a12e42-e20a-b561-76ed-7fa48d4b520a@lab.ntt.co.jp>
	<6c651916-8fde-f9c9-b199-080df1bf2867@lab.ntt.co.jp>
	<280720c5-7aad-1136-6be3-654208c8f714@lab.ntt.co.jp>
	<8065.1500475011@sss.pgh.pa.us>
	<9cd25d80-08fc-568c-3181-dbe98723d0db@lab.ntt.co.jp>
	<3e9ff40d-d00f-3363-dcee-97ce023c7884@lab.ntt.co.jp>
	<f8aa99d0-627d-32dc-fbc7-4e5943f9d652@lab.ntt.co.jp>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On Mon, 24 Jul 2017 11:59:13 +0900
Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> wrote:

> On 2017/07/21 19:16, Etsuro Fujita wrote:
> > On 2017/07/20 11:21, Etsuro Fujita wrote:  
> >> On 2017/07/19 23:36, Tom Lane wrote:  
> >>> Please put the responsibility of doing const-expression
> >>> simplification in these cases somewhere closer to where the
> >>> problem is being created.  
> >>
> >> It would be reasonable that it's the FDW's responsibility to do
> >> that const-simplification if necessary?  
> > There seems to be no objections, so I removed the const-expression 
> > simplification from the patch and I added the note to the docs for 
> > AddForeignUpdateTargets.
> > 
> > Attached is an updated version of the patch.  
> 
> I cleaned up the patch a bit.  PFA a new version of the patch.
> 
> Best regards,
> Etsuro Fujita

Checked, looks good to me. Changed status to 'Ready for Commiter'.

-- 
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (43+ messages)  latest in thread

Message-ID: <20170912182622.608b47c4@wp.localdomain>
Permalink:  ../20170912182622.608b47c4@wp.localdomain/
Also on:    postgresql.org/message-id/20170912182622.608b47c4@wp.localdomain

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: i.kurbangaliev@postgrespro.ru, fujita.etsuro@lab.ntt.co.jp, tgl@sss.pgh.pa.us, ashutosh.bapat@enterprisedb.com, dilipbalaut@gmail.com, robertmhaas@gmail.com
  Subject: Re: Bug in ExecModifyTable function and trigger issues for foreign tables
  In-Reply-To: <20170912182622.608b47c4@wp.localdomain>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox