pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: Pre-existing bug in trigger.c
Date: Tue, 19 Sep 2017 10:41:51 +0200
Message-ID: <20170919084151.slpsbmero7lzth5u@alvherre.pgsql> (raw)
In-Reply-To: <1976.1505599106@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Tom Lane wrote:

> After studying this awhile, I've concluded that neither of those
> ideas leads to a fix simple enough that I'd be comfortable with
> back-patching it.  What seems like the best answer is to not pass
> delete_ok = true to afterTriggerInvokeEvents in AfterTriggerEndQuery.
> Then, afterTriggerInvokeEvents will examine the passed event list
> pointer only during its loop initialization, at which time it's
> surely still valid.

For reference: this fix was committed as 27c6619e9c8f.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (3+ messages)

Message-ID: <20170919084151.slpsbmero7lzth5u@alvherre.pgsql>
Permalink:  ../20170919084151.slpsbmero7lzth5u@alvherre.pgsql/
Also on:    postgresql.org/message-id/20170919084151.slpsbmero7lzth5u@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, tgl@sss.pgh.pa.us
  Subject: Re: Pre-existing bug in trigger.c
  In-Reply-To: <20170919084151.slpsbmero7lzth5u@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox