From: Anthony Bykov <a.bykov@postgrespro.ru>
To: pgsql-hackers@postgresql.org
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: Rewriting PL/Python's typeio code
Date: Wed, 15 Nov 2017 11:08:23 +0000
Message-ID: <20171115110823.1377.63193.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <24449.1509393613@sss.pgh.pa.us>
References: <24449.1509393613@sss.pgh.pa.us>
<24449.1509393613@sss.pgh.pa.us>
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: not tested
Spec compliant: not tested
Documentation: tested, passed
Hello,
I have checked your patch. Everything looks fine for me, but I have some doubts:
1. In file plpy_exec.c there is a typo on line 347:
"... We use the result and resultin[should be here "g"?] variables...
2. In file plpy_cursorobject.c there is a non-volatile variable "elem" used in try-except construction. Is that OK?
--
Anthony Bykov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
The new status of this patch is: Waiting on Author
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.bykov@postgrespro.ru, tgl@sss.pgh.pa.us
Subject: Re: Rewriting PL/Python's typeio code
In-Reply-To: <20171115110823.1377.63193.pgcf@coridan.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox