pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Anthony Bykov <a.bykov@postgrespro.ru>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Rewriting PL/Python's typeio code
Date: Thu, 16 Nov 2017 16:25:03 -0500
Message-ID: <7578.1510867503@sss.pgh.pa.us> (raw)
In-Reply-To: <28605.1510759393@sss.pgh.pa.us>
References: <24449.1509393613@sss.pgh.pa.us>
	<24449.1509393613@sss.pgh.pa.us>
	<20171115110823.1377.63193.pgcf@coridan.postgresql.org>
	<28605.1510759393@sss.pgh.pa.us>

I wrote:
> Anthony Bykov <a.bykov@postgrespro.ru> writes:
>> 1. In file plpy_exec.c there is a typo on line 347:
>> "... We use the result and resultin[should be here "g"?] variables...

> No, "resultin" is the name of the variable.  Maybe that wasn't a good
> choice of name, though --- do you have a better idea?

After some thought I went with "result_in", which hopefully looks less
like a typo.  Thanks again for reviewing.

			regards, tom lane




view thread (4+ messages)

Message-ID: <7578.1510867503@sss.pgh.pa.us>
Permalink:  ../7578.1510867503@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/7578.1510867503@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, a.bykov@postgrespro.ru, pgsql-hackers@lists.postgresql.org
  Subject: Re: Rewriting PL/Python's typeio code
  In-Reply-To: <7578.1510867503@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox