From: Aleksander Alekseev <a.alekseev@postgrespro.ru>
To: pgsql-hackers@postgresql.org
Cc: Victor Drobny <v.drobny@postgrespro.ru>
Subject: Re: new function for tsquery creartion
Date: Tue, 28 Nov 2017 17:57:00 +0300
Message-ID: <20171128145659.GA32487@e733.localdomain> (raw)
In-Reply-To: <20171128143916.1377.5847.pgcf@coridan.postgresql.org>
References: <fe931111ff7e9ad79196486ada79e268@postgrespro.ru>
<15517a04afd2be779e2e6d69611c348b@postgrespro.ru>
<20171128143916.1377.5847.pgcf@coridan.postgresql.org>
Hi Victor,
> I like the idea and I think it's a great patch. However in current shape it
> requires some amount of reworking to meet PostgreSQL standards of code quality.
Also I would like to add that I agree with Thomas Munro:
> Calling this search syntax just "query" seems too general and
> overloaded. "Simple search", "simple query", "web search", "web
> syntax", "web query", "Google-style query", "Poogle" (kidding!) ...
> well I'm not sure, but I feel like it deserves a proper name.
> websearch_to_tsquery()?
websearch_to_tsquery() sounds much better than query_to_tsquery().
Also I agree Tomas Vondra in regard that:
> 2) I don't think we should mention Google in the docs explicitly. Not
> that I'm somehow anti-google, but this syntax was certainly not invented
> by Google - I vividly remember using something like that on Altavista
> (yeah, I'm old). And it's used by pretty much every other web search
> engine out there ...
I suggest to rephrase:
```
+ about its input. <function>queryto_tsquery</function> provides a
+ different, Google like syntax to create tsquery.
```
.. to something more like "provides a different syntax, similar to one
used in web search engines, to create tsqeury". And maybe give a few
examples right in the next sentence.
--
Best regards,
Aleksander Alekseev
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.alekseev@postgrespro.ru, v.drobny@postgrespro.ru
Subject: Re: new function for tsquery creartion
In-Reply-To: <20171128145659.GA32487@e733.localdomain>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox