pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Юрий Соколов <funny.falcon@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Claudio Freire <klaussfreire@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Sokolov Yura <funny.falcon@postgrespro.ru>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: PostgreSQL-Dev <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Small improvement to compactify_tuples
Date: Tue, 28 Nov 2017 14:41:50 -0800
Message-ID: <20171128224150.syswowiaiojth7ke@alap3.anarazel.de> (raw)
In-Reply-To: <CAL-rCA3=MiVU7SWenhPL0a3e5KfOkzvXZDp_WL+ea2Ky57Fqdg@mail.gmail.com>
References: <20171107152004.axgznk3n5tkzvnnt@alap3.anarazel.de>
	<29007.1510090796@sss.pgh.pa.us>
	<CA+TgmobyDksaVkoj=VTFovcw02mMBrjsbx7F9Nvm4tXTHU6HfQ@mail.gmail.com>
	<19570.1510155199@sss.pgh.pa.us>
	<CAGTBQpZgs4hVmDtHg4F6MDJuAE9-U=z6d+yJzjPsZup7AZhV0Q@mail.gmail.com>
	<22996.1510160560@sss.pgh.pa.us>
	<CAL-rCA3n4Neat4pH382nuZ9v0-SCZOBJ=KHT5CoBGXim=KTAhw@mail.gmail.com>
	<CAL-rCA2cCyvapkb15fADR3qKsRMo+XimPgmGviur1ui-y0q-aQ@mail.gmail.com>
	<CAH2-WznEQBxeij1_PnczUD=vQqS0aPWOxJAkmjH_rXoBpeo0ZQ@mail.gmail.com>
	<CAL-rCA3=MiVU7SWenhPL0a3e5KfOkzvXZDp_WL+ea2Ky57Fqdg@mail.gmail.com>

Hi,

On 2017-11-28 23:30:53 +0300, Юрий Соколов wrote:
> index 1a8ee08c8b..607ed6a781 100644
> --- a/src/port/qsort.c
> +++ b/src/port/qsort.c
> @@ -8,7 +8,7 @@
>   *	  in favor of a simple check for presorted input.
>   *	  Take care to recurse on the smaller partition, to bound stack usage.
>   *
> - *	CAUTION: if you change this file, see also qsort_arg.c, gen_qsort_tuple.pl
> + *	CAUTION: if you change this file, see also qsort_arg.c, qsort_template.h
>   *
>   *	src/port/qsort.c
>   */

Maybe it's a stupid question. But would we still want to have this after
the change? These should be just specializations of the template version
imo.

Greetings,

Andres Freund




view thread (60+ messages)  latest in thread

Message-ID: <20171128224150.syswowiaiojth7ke@alap3.anarazel.de>
Permalink:  ../20171128224150.syswowiaiojth7ke@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20171128224150.syswowiaiojth7ke@alap3.anarazel.de

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andres@anarazel.de, funny.falcon@gmail.com, pg@bowt.ie, tgl@sss.pgh.pa.us, klaussfreire@gmail.com, robertmhaas@gmail.com, funny.falcon@postgrespro.ru, alvherre@2ndquadrant.com, hlinnaka@iki.fi
  Subject: Re: [HACKERS] Small improvement to compactify_tuples
  In-Reply-To: <20171128224150.syswowiaiojth7ke@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox