From: David Fetter <david@fetter.org>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: [HACKERS] Something for the TODO list: deprecating abstime and friends
Date: Sun, 17 Dec 2017 23:24:19 +0100
Message-ID: <20171217222419.GA30764@fetter.org> (raw)
In-Reply-To: <20171213080506.cwjkpcz3bkk6yz2u@alap3.anarazel.de>
References: <30691.1500156034@sss.pgh.pa.us>
<20171213080506.cwjkpcz3bkk6yz2u@alap3.anarazel.de>
On Wed, Dec 13, 2017 at 12:05:06AM -0800, Andres Freund wrote:
> On 2017-07-15 18:00:34 -0400, Tom Lane wrote:
> > * contrib/spi/timetravel depends on abstime columns to represent what
> > would nowadays be better done as a tstzrange. I'd have thought we
> > could maybe toss that example module overboard, but we just today got
> > a question about its usage, so I'm afraid it's not quite dead yet.
> > What shall we do with that?
>
> Looking at the code I'd be pretty strongly inclined to scrap it.
>
>
> Before I'd discovered this thread, I'd started to write up a
> patch. Attached. It's clearly not fully done. Questions I'd while
> hacking things up:
> - what to do with contrib/spi/timetravel - I'd just removed it from the
> relevant Makefile for now.
Porting it to tstzrange seems friendlier, however:
- Does that look like significant work to do this port?
- How about the work involved with upgrading existing installations?
> - nabstime.c currently implements timeofday() which imo is a pretty
> weird function. I'd be quite inclined to remove it at the same time as
> this.
+1 for binning it.
Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@fetter.org, andres@anarazel.de, tgl@sss.pgh.pa.us
Subject: Re: [HACKERS] Something for the TODO list: deprecating abstime and friends
In-Reply-To: <20171217222419.GA30764@fetter.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox