From: Stephen Frost <sfrost@snowman.net>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: michael.paquier@gmail.com
Cc: thomas.munro@enterprisedb.com
Cc: tgl@sss.pgh.pa.us
Cc: alvherre@2ndquadrant.com
Cc: david@pgmasters.net
Cc: hlinnaka@iki.fi
Cc: simon@2ndquadrant.com
Cc: andres@anarazel.de
Cc: masao.fujii@gmail.com
Cc: kleptog@svana.org
Cc: pgsql-hackers@postgresql.org
Subject: Re: [HACKERS] WAL logging problem in 9.4.3?
Date: Thu, 4 Jan 2018 23:10:40 -0500
Message-ID: <20180105041040.GI2416@tamriel.snowman.net> (raw)
In-Reply-To: <20171211.175424.09346818.horiguchi.kyotaro@lab.ntt.co.jp>
References: <20170913.174239.25978735.horiguchi.kyotaro@lab.ntt.co.jp>
<20170914.153459.94374240.horiguchi.kyotaro@lab.ntt.co.jp>
<CAB7nPqSqukqS5Xx6_6KEk53eRy5ObdvaNG-5aN_4cE8=gTeOdg@mail.gmail.com>
<20171211.175424.09346818.horiguchi.kyotaro@lab.ntt.co.jp>
Greetings,
* Kyotaro HORIGUCHI (horiguchi.kyotaro@lab.ntt.co.jp) wrote:
> At Tue, 28 Nov 2017 10:36:39 +0900, Michael Paquier <michael.paquier@gmail.com> wrote in <CAB7nPqSqukqS5Xx6_6KEk53eRy5ObdvaNG-5aN_4cE8=gTeOdg@mail.gmail.com>
> > On Thu, Sep 14, 2017 at 3:34 PM, Kyotaro HORIGUCHI
> > <horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> > > At Wed, 13 Sep 2017 17:42:39 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote in <20170913.174239.25978735.horiguchi.kyotaro@lab.ntt.co.jp>
> > >> filterdiff seems to did something wrong..
> > >
> > > # to did...
>
> It's horrid to see that:p
>
> > > The patch is broken by filterdiff so I send a new patch made
> > > directly by git format-patch. I confirmed that a build completes
> > > with applying this.
> >
> > To my surprise this patch still applies but fails recovery tests. I am
> > bumping it to next CF, for what will be its 8th registration as it is
> > for a bug fix, switching the status to "waiting on author".
>
> Thank you for checking that. I saw maybe the same failure. It
> occurred when visibilitymap_set() is called with heapBuf =
> InvalidBuffer during recovery. Checking pendingSyncs and
> no_pending_sync before the elog fixes it. Anyway the DEBUG2 elogs
> are to removed before committing. They are just to look how it
> works.
>
> The attached patch applies on the current HEAD and passes all
> recovery tests.
This is currently marked as 'waiting on author' in the CF app, but it
sounds like it should be 'Needs review'. If that's the case, please
update the CF app accordingly. If you run into any issues with that,
let me know.
Thanks!
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20180105041040.GI2416@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, horiguchi.kyotaro@lab.ntt.co.jp, michael.paquier@gmail.com, thomas.munro@enterprisedb.com, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, david@pgmasters.net, hlinnaka@iki.fi, simon@2ndquadrant.com, andres@anarazel.de, masao.fujii@gmail.com, kleptog@svana.org
Subject: Re: [HACKERS] WAL logging problem in 9.4.3?
In-Reply-To: <20180105041040.GI2416@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox