pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Stephen Frost <sfrost@snowman.net>
To: Rady, Doug <radydoug@amazon.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: pgbench - option to build using ppoll() for larger connection counts
Date: Sat, 6 Jan 2018 16:49:25 -0500
Message-ID: <20180106214925.GM2416@tamriel.snowman.net> (raw)
In-Reply-To: <3B729131-C891-41F3-B911-8DEB05515D63@amazon.com>
References: <3B729131-C891-41F3-B911-8DEB05515D63@amazon.com>

Doug,

* Rady, Doug (radydoug@amazon.com) wrote:
> This patch enables building pgbench to use ppoll() instead of select()
> to allow for more than (FD_SETSIZE - 10) connections.  As implemented,
> when using ppoll(), the only connection limitation is system resources.

Looks like this patch had some good feedback back when it was posted,
but we haven't seen any update to it based on that feedback and we're
now nearly a week into the January commitfest.

In order to keep the commitfest moving and to give you the best
opportunity at having the patch be reviewed and committed during this
cycle, I'd suggest trying to find some time soon to incorporate the
recommendations provided and post an updated patch for review.

Thanks!

Stephen

Attachments:

  [application/pgp-signature] signature.asc (818B, ../20180106214925.GM2416@tamriel.snowman.net/2-signature.asc)
  download

view thread (51+ messages)  latest in thread

Message-ID: <20180106214925.GM2416@tamriel.snowman.net>
Permalink:  ../20180106214925.GM2416@tamriel.snowman.net/
Also on:    postgresql.org/message-id/20180106214925.GM2416@tamriel.snowman.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: sfrost@snowman.net, radydoug@amazon.com
  Subject: Re: PATCH: pgbench - option to build using ppoll() for larger connection counts
  In-Reply-To: <20180106214925.GM2416@tamriel.snowman.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox