pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Ildar Musin <i.musin@postgrespro.ru>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: IndexTupleDSize macro seems redundant
Date: Thu, 11 Jan 2018 21:17:19 -0500
Message-ID: <20180112021719.GU2416@tamriel.snowman.net> (raw)
In-Reply-To: <24410.1515712748@sss.pgh.pa.us>
References: <0274288e-9e88-13b6-c61c-7b36928bf221@postgrespro.ru>
	<CAA4eK1+qNuT2iY+gL-yi-Sn-aj=2y7hBD3GFFRrxh6hV-U+X6w@mail.gmail.com>
	<CA+TgmoaBZi-oNU4dK-FBDeqRWijxYKc5Lne2hD7+bn+sXKuT3g@mail.gmail.com>
	<20180111172241.GK2416@tamriel.snowman.net>
	<8984.1515692863@sss.pgh.pa.us>
	<20180111181713.GN2416@tamriel.snowman.net>
	<20180111203250.GR2416@tamriel.snowman.net>
	<24410.1515712748@sss.pgh.pa.us>

Tom,

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > Updated (combined) patch attached for review.  I went through and looked
> > again to make sure there weren't any cases of making an unaligned
> > pointer to a struct and didn't see any, and I added some comments to
> > _bt_restore_page().
> 
> Looks OK from here.

Great, thanks, I'll mark it as Ready For Committer then.

Robert, since you were on this thread and the patch is mostly yours
anyway, did you want to commit it?  I'm happy to do so also, either way.

Thanks!

Stephen

Attachments:

  signature.asc (application/pgp-signature, 818B) download

view thread (15+ messages)  latest in thread

Message-ID: <20180112021719.GU2416@tamriel.snowman.net>
Permalink:  ../20180112021719.GU2416@tamriel.snowman.net/
Also on:    postgresql.org/message-id/20180112021719.GU2416@tamriel.snowman.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, amit.kapila16@gmail.com, i.musin@postgrespro.ru
  Subject: Re: IndexTupleDSize macro seems redundant
  In-Reply-To: <20180112021719.GU2416@tamriel.snowman.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox